[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#883523: xpdf: FTBFS with poppler 0.61.1



On Thu, Dec 14, 2017 at 01:14:24PM +0000, peter green wrote:
>...
> Unfortunately the build then goes on to fail in another file
> 
> build/XPDFParams.cc: In member function ‘void XPDFParams::parseScreenType(GooList*, GooString*, int)’:
> build/XPDFParams.cc:1631:19: error: ‘class GlobalParams’ has no member named ‘setScreenType’; did you mean ‘setEnableFreeType’?
>      globalParams->setScreenType(screenDispersed);
>                    ^~~~~~~~~~~~~
>                    setEnableFreeType
> compilation terminated due to -Wfatal-errors.
> <builtin>: recipe for target 'build/XPDFParams.o' failed
> 
> Any thoughts?
>...

The attached patch is a big hammer that disables the non-compling code.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Description: Hacks to compile with poppler 0.61
 - disable screenType setting
 - disable Movie action
Author: Adrian Bunk <bunk@debian.org>
Bug-Debian: https://bugs.debian.org/883523

--- xpdf-3.04.orig/xpdf/GlobalParams.cc
+++ xpdf-3.04/xpdf/GlobalParams.cc
@@ -1174,8 +1174,8 @@ void GlobalParams::parseLine(char *buf,
     /*
     } else if (!cmd->cmp("strokeAdjust")) {
       parseYesNo("strokeAdjust", &strokeAdjust, tokens, fileName, line);
-    } else if (!cmd->cmp("screenType")) {
-      parseScreenType(tokens, fileName, line);
+//    } else if (!cmd->cmp("screenType")) {
+//      parseScreenType(tokens, fileName, line);
     } else if (!cmd->cmp("screenSize")) {
       parseInteger("screenSize", &screenSize, tokens, fileName, line);
     } else if (!cmd->cmp("screenDotRadius")) {
@@ -1617,6 +1617,7 @@ void GlobalParams::parseInitialZoom(GLis
   initialZoom = ((GString *)tokens->get(1))->copy();
 }
 
+/*
 void GlobalParams::parseScreenType(GList *tokens, GString *fileName,
 				   int line) {
   GString *tok;
@@ -1638,6 +1639,7 @@ void GlobalParams::parseScreenType(GList
 	  fileName, line);
   }
 }
+*/
 
 
 void GlobalParams::parseBind(GList *tokens, GString *fileName, int line) {
--- xpdf-3.04.orig/xpdf/XPDFCore.cc
+++ xpdf-3.04/xpdf/XPDFCore.cc
@@ -684,6 +684,8 @@ void XPDFCore::doAction(LinkAction *acti
 
   // Movie action
   case actionMovie:
+
+/*
     if (!(cmd = xpdfParams->getMovieCommand())) {
       error(errConfig, -1, "No movieCommand defined in config file");
       break;
@@ -732,6 +734,8 @@ void XPDFCore::doAction(LinkAction *acti
       }
     }
     movieAnnot.free();
+*/
+    error(errSyntaxError, -1, "Movie action needs fixing");
     break;
 
   // unsupported action types

Reply to: