[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#845718: marked as done (maildir-filter: link against -lpcre in LIBS instead of LDFLAGS)

Your message dated Thu, 11 Jan 2018 13:19:59 +0000
with message-id <E1eZclz-000COs-FN@fasolo.debian.org>
and subject line Bug#845718: fixed in maildir-filter 1.20-5
has caused the Debian Bug report #845718,
regarding maildir-filter: link against -lpcre in LIBS instead of LDFLAGS
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
845718: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845718
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: maildir-filter
Version: 1.20-4
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu zesty ubuntu-patch

Dear Maintainer,

LDFLAGS should only be used for linker options, not for libraries to link
against. Putting libraries here breaks linkers that use the --as-needed flag
(such as in Ubuntu), since they expect the libraries after the files that
need them.

LIBS should be used instead.

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/rules: Remove -lpcre from DEB_LDFLAGS_MAINT_APPEND; it doesn't
    belong in that Makefile variable.
  * debian/patches/makefile_flags_and_dir: Update to add -lpcre to the LIBS
    variable.

Thanks for considering the patch.

Logan Rosen

-- System Information:
Debian Release: stretch/sid
  APT prefers yakkety-updates
  APT policy: (500, 'yakkety-updates'), (500, 'yakkety-security'), (500, 'yakkety'), (100, 'yakkety-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-21-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.utf8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

diff -Nru maildir-filter-1.20/debian/patches/makefile_flags_and_dir maildir-filter-1.20/debian/patches/makefile_flags_and_dir
--- maildir-filter-1.20/debian/patches/makefile_flags_and_dir	2016-09-16 18:31:51.000000000 -0400
+++ maildir-filter-1.20/debian/patches/makefile_flags_and_dir	2016-11-25 23:07:21.000000000 -0500
@@ -3,15 +3,14 @@
         Samuel Henrique <samueloph@gmail.com>
 Last-Update: 2016-09-16
 
-Index: maildir-filter-1.20/Makefile
-===================================================================
---- maildir-filter-1.20.orig/Makefile
-+++ maildir-filter-1.20/Makefile
-@@ -1,11 +1,10 @@
+--- a/Makefile
++++ b/Makefile
+@@ -1,11 +1,11 @@
  CC=gcc
 -CFLAGS=-O6 -pipe -g -Werror -Wall
 -LDFLAGS=-lpcre
  BINNAME=maildir-filter
++LIBS+=-lpcre
  
  all: maildir-filter
  
@@ -20,7 +19,7 @@
  	cp maildir-filter $(DESTDIR)/usr/bin/${BINNAME}
  	chmod 755 $(DESTDIR)/usr/bin/${BINNAME}
  	chown root.root $(DESTDIR)/usr/bin/${BINNAME}
-@@ -15,6 +14,7 @@ update-templates:
+@@ -15,6 +15,7 @@
  	-xgettext -d maildir-filter -j -o po/maildir-filter.pot -k_ -T maildir-filter.c 
  
  maildir-filter: maildir-filter.o
diff -Nru maildir-filter-1.20/debian/rules maildir-filter-1.20/debian/rules
--- maildir-filter-1.20/debian/rules	2016-09-16 18:31:24.000000000 -0400
+++ maildir-filter-1.20/debian/rules	2016-11-25 23:03:42.000000000 -0500
@@ -1,7 +1,6 @@
 #!/usr/bin/make -f
 
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-export DEB_LDFLAGS_MAINT_APPEND = -lpcre
 
 %:
 	dh $@

--- End Message ---
--- Begin Message --- 
Source: maildir-filter
Source-Version: 1.20-5

We believe that the bug you reported is fixed in the latest version of
maildir-filter, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 845718@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gianfranco Costamagna <locutusofborg@debian.org> (supplier of updated maildir-filter package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 11 Jan 2018 14:03:48 +0100
Source: maildir-filter
Binary: maildir-filter
Architecture: source
Version: 1.20-5
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Gianfranco Costamagna <locutusofborg@debian.org>
Description:
 maildir-filter - Simple program to filter messages into Maildir folders from dot-q
Closes: 845718
Changes:
 maildir-filter (1.20-5) unstable; urgency=medium
 .
   * QA upload.
   * Switch compat level to 10
   * Bump std-version to 4.1.3, remove priority extra
 .
   [ Logan Rosen ]
   * Fixup link against -lpcre in LIBS instead of LDFLAGS
     (Closes: #845718)
Checksums-Sha1:
 52188ec6676c0542628af2b5c7e1a41cd56e7545 1691 maildir-filter_1.20-5.dsc
 511fb5a413647152e5b9d0fd53be0d7267080099 4048 maildir-filter_1.20-5.debian.tar.xz
 28dd44eb11d65053013c861ab794d737e3bbc9cf 6621 maildir-filter_1.20-5_source.buildinfo
Checksums-Sha256:
 579d4d5717c5136368aa2ae934a4cb8e5525d5715858f2fffb6b043fdf9cc946 1691 maildir-filter_1.20-5.dsc
 94e2cbcf2a4fae2b4a8929a0e3a1dd88f0afea2cda857e53877c7ba18c4ac83b 4048 maildir-filter_1.20-5.debian.tar.xz
 88b87f3d578215069f54cad61914dc3848f794e34c6f7d7b00a3603b93a1d5fe 6621 maildir-filter_1.20-5_source.buildinfo
Files:
 7236bc3a717342a1d737d0333367dc52 1691 mail - maildir-filter_1.20-5.dsc
 7bcd5e0884e16f31533d88b9e3d61b71 4048 mail - maildir-filter_1.20-5.debian.tar.xz
 0fe4b547c3abbcfd79df81d973231ddf 6621 mail - maildir-filter_1.20-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJaV2EJAAoJEPNPCXROn13Z25IP/jnJfgY3zO5dkkcfkVhPLGr6
J3oDrve8vzcBG1CiOPeCAjCb+jxVLa0mB29HOd+TsygGVt4OkawUoaD8XquSW3dI
vX7RtKxh71AkL5sdqtKGK+8QTzayAJ8mNgFiRNR7VQRAU4tL+y8FQ94x9vOcuLRY
Q9vqX9BxY9MtQRrUYOiNzSCRjABS5k4u0AjJNE4JJULXPDLnRjmnDIeXcBUyAaeP
29HzsCZ09txp68OBCIHCnQQ5sO38A3NMB05qWIKnEMBKVnu9PSaRHLpyzmXtc4wy
Gkh2+RS3o9yTvbIM6uT4wl1T7d3KtxfGirbguX30NbKY/IaH+zS98ppFxS6FAhu7
g5WdyBkvcL0fLBc2ZrV2+1mu7I4+IgkySMoFVr9yPNxLvP/VMoTcgoCkHQfAwhj1
6A5CXNR+Oiffbzz/hnby7Pu74cIJCwGKnp6kWCmGeQFHx9+2PX6NzvWUyVPDbHXl
559xEi4O4omJfBj47pEjrwiXX805AAc9ECbQBG3i/ZBifZ2y1jEwFOmagg9XWB/z
7Oh8ENjQJSbHymffkyanodpRqnbDDWPgFV0ot3DbfxOZaC3itxB2qJ543cdWK/nn
Tq61//YMAT7UURRUqscz2FxPTg2gdPumQKG4Y9IVcW6L4bs7NpF0zGqFIlra94TH
ZhQECsASKwaRpL+QEKpE
=XJ6D
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: