[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#915146: ioprocess: FTBFS with ld --as-needed



Package: ioprocess
Version: 0.15.1-3
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu disco ubuntu-patch

Dear Maintainer,

ioprocess fails to build from source when the ld linker is configured to
use the --as-needed option, which requires that libraries be in a
certain order. This is the default in Ubuntu.

While this isn't strictly necessary in Debian, it puts the libraries in the
right place and will let us avoid having to maintain a delta.

In Ubuntu, the attached patch was applied to achieve the following:

  * Merge from Debian unstable. Remaining changes:
    - Use LDADD instead of LDFLAGS to fix FTBFS with ld --as-needed.

Thanks for considering the patch.

Logan

-- System Information:
Debian Release: buster/sid
  APT prefers cosmic-updates
  APT policy: (500, 'cosmic-updates'), (500, 'cosmic-security'), (500, 'cosmic'), (400, 'cosmic-proposed'), (100, 'cosmic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.18.0-11-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru ioprocess-0.15.1/debian/patches/ld-as-needed.patch ioprocess-0.15.1/debian/patches/ld-as-needed.patch
--- ioprocess-0.15.1/debian/patches/ld-as-needed.patch	1969-12-31 19:00:00.000000000 -0500
+++ ioprocess-0.15.1/debian/patches/ld-as-needed.patch	2016-01-31 23:54:06.000000000 -0500
@@ -0,0 +1,17 @@
+Description: use LDADD instead of LDFLAGS to fix FTBFS with ld --as-needed
+Author: Logan Rosen <logan@ubuntu.com>
+Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1304958
+Last-Update: 2016-02-05
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -14,7 +14,7 @@
+ 		   $(IOPROCESS_CFLAGS) \
+ 		   $(AM_CFLAGS) \
+ 		   $(NULL)
+-ioprocess_LDFLAGS = $(GLIB2_LIBS) \
++ioprocess_LDADD = $(GLIB2_LIBS) \
+ 		    $(GTHREAD2_LIBS) \
+ 		    $(YAJL_LIBS) \
+ 		    $(AM_LDFLAGS) \
diff -Nru ioprocess-0.15.1/debian/patches/series ioprocess-0.15.1/debian/patches/series
--- ioprocess-0.15.1/debian/patches/series	2016-01-18 10:37:22.000000000 -0500
+++ ioprocess-0.15.1/debian/patches/series	2018-07-11 12:57:55.000000000 -0400
@@ -1 +1,2 @@
 paths.patch
+ld-as-needed.patch

Reply to: