Bug#883523: xpdf: FTBFS with poppler 0.61.1

[Florian Schlichting <fsfs@debian.org>]

Hi Peter,

the patch you attached is the unmodified
debian/patches/poppler-xpdfparams.patch - did you intend to attach a
different file, which shows your actual work on XPDFCore.cc
(presumably)?

Florian

On Thu, Dec 14, 2017 at 01:14:24PM +0000, peter green wrote:
> I just took a look at the xpdf build failure.
> 
> Unfortunately I was unable to find documentation on the "object" changes but after reading the sourcecode I was able to figure out that.
> 
> 1. It appears "output" objects are now returned by value rather than being passed by pointer.
> 2. Freeing objects is now handled automatically by destructors etc and is no longer allowed to be done manually.
> 3. dictLookup now seems to return a "Null" object on failure.
> 4. getFileSpecNameForPlatform now seems to return a "None" object on failure.
> 
> Based on these figurings out I was able to make the file build. Patch attatched.
> 
> Unfortunately the build then goes on to fail in another file
> 
> build/XPDFParams.cc: In member function ‘void XPDFParams::parseScreenType(GooList*, GooString*, int)’:
> build/XPDFParams.cc:1631:19: error: ‘class GlobalParams’ has no member named ‘setScreenType’; did you mean ‘setEnableFreeType’?
>      globalParams->setScreenType(screenDispersed);
>                    ^~~~~~~~~~~~~
>                    setEnableFreeType
> compilation terminated due to -Wfatal-errors.
> <builtin>: recipe for target 'build/XPDFParams.o' failed
> 
> Any thoughts?
> 
> 

> description: split responsibility for global parameters into separate poppler and xpdf classes
> author: Michael Gilbert <mgilbert@debian.org>
> author: Dmitry Shachnev <mitya57@ubuntu.com>
> bug-debian: http://bugs.debian.org/640515
> bug-ubuntu: https://bugs.launchpad.net/bugs/943195
> bug-ubuntu: https://bugs.launchpad.net/bugs/1205732
> 
> --- a/xpdf/PDFCore.cc
> +++ b/xpdf/PDFCore.cc
> @@ -18,6 +18,7 @@
>  #include "GString.h"
>  #include "GList.h"
>  #include "GlobalParams.h"
> +#include "XPDFParams.h"
>  #include "Splash.h"
>  #include "SplashBitmap.h"
>  #include "SplashPattern.h"
> @@ -86,7 +87,7 @@
>    int i;
>  
>    doc = NULL;
> -  continuousMode = globalParams->getContinuousView();
> +  continuousMode = xpdfParams->getContinuousView();
>    drawAreaWidth = drawAreaHeight = 0;
>    maxPageW = totalDocH = 0;
>    pageY = NULL;

...