[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#874183: xmlrpc-c FTCBFS: runs host architecture binaries



Source: xmlrpc-c
Version: 1.33.14-4
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

xmlrpc-c fails to cross build from source, because it fails running
gennmtab, which was built with the host architecture compiler. gennmtab
is part of an embedded code copy of expat. In any case, it is built with
BUILDTOOL_CC which strangely ends up being the host architecture
compiler. Properly setting BUILDTOOL_CC (and BUILDTOOL_CCLD) fixes that.
Further down the road, debian/rules unconditionally runs "make check"
(even when DEB_BUILD_OPTIONS=nocheck) and naturally fails doing so.
After also honouring DEB_BUILD_OPTIONS=nocheck, xmlrpc-c cross builds
successfully. Please consider applying the attached patch.

Also moving "make check" to override_dh_auto_test might make sense
conceptually.

Helmut
diff --minimal -Nru xmlrpc-c-1.33.14/debian/changelog xmlrpc-c-1.33.14/debian/changelog
--- xmlrpc-c-1.33.14/debian/changelog	2017-03-10 23:41:13.000000000 +0100
+++ xmlrpc-c-1.33.14/debian/changelog	2017-09-03 22:38:02.000000000 +0200
@@ -1,3 +1,12 @@
+xmlrpc-c (1.33.14-4.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Set BUILDTOOL_CC.
+    + Do not run make check when DEB_BUILD_OPTIONS=nocheck.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sun, 03 Sep 2017 22:38:02 +0200
+
 xmlrpc-c (1.33.14-4) unstable; urgency=medium
 
   * QA upload.
diff --minimal -Nru xmlrpc-c-1.33.14/debian/rules xmlrpc-c-1.33.14/debian/rules
--- xmlrpc-c-1.33.14/debian/rules	2017-03-10 23:41:13.000000000 +0100
+++ xmlrpc-c-1.33.14/debian/rules	2017-09-03 22:38:02.000000000 +0200
@@ -19,9 +19,11 @@
 		--disable-wininet-client
 
 override_dh_auto_build:
-	dh_auto_build
+	dh_auto_build -- BUILDTOOL_CC=gcc 'BUILDTOOL_CCLD=$$(BUILDTOOL_CC)'
 	( cd tools && make )
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
 	make check
+endif
 
 override_dh_auto_clean:
 	rm -f build-arch-stamp build-indep-stamp

Reply to: