Bug#873156: fofix: FoFiX.py rises a NotImplementedError on startup

[Christian Trenkwalder <christian@trenkwalder.it>]

Package: fofix
Version: 3.121-4
Severity: important
Tags: patch

Dear Maintainer,
after installing the fofix package on a (up-to-date) system, 
the application terminates due to unhandlet exception.
This is caused by the usage of the removed 'tostring()' within python and python suggests 'tobytes()' should be used instead. 

After replacing the tostring() calls with tobytes() as suggested, 
the application becomes usable.

I have attached a diff at the end of the report.

kind regards
Christian


-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.11.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_AT.utf8, LC_CTYPE=de_AT.utf8 (charmap=UTF-8), LANGUAGE=de_AT:de (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages fofix depends on:
ii  python          2.7.13-2
ii  python-imaging  4.2.1-1
ii  python-numpy    1:1.12.1-3+b2
ii  python-opengl   3.1.0+dfsg-1
ii  python-pygame   1.9.1release+dfsg-10+b2

Versions of packages fofix recommends:
ii  python-ogg       1.3+repack-7
ii  python-pyaudio   0.2.11-1+b1
ii  python-pyvorbis  1.5-4

Versions of packages fofix suggests:
pn  python-psyco  <none>

-- no debconf information

-- Diff after patching:

30c30
< 
---
> 
77c77
<       string = image.tostring('raw', 'RGBA', 0, -1)
---
>       string = image.tobytes('raw', 'RGBA', 0, -1)
80c80
<       string = image.tostring('raw', 'RGB', 0, -1)
---
>       string = image.tobytes('raw', 'RGB', 0, -1)
83c83
<       string = image.tostring('raw', 'L', 0, -1)
---
>       string = image.tobytes('raw', 'L', 0, -1)
89c89
<         string = image.tostring('raw', 'RGB', 0, -1)
---
>         string = image.tobytes('raw', 'RGB', 0, -1)
114c114
<       string = pygame.image.tostring(surface, "RGB")
---
>       string = pygame.image.tobytes(surface, "RGB")
116c116
<       string = image.tostring('raw', 'L', 0, -1)
---
>       string = image.tobytes('raw', 'L', 0, -1)
120c120
<         string = pygame.image.tostring(surface, "RGBA", True)
---
>         string = pygame.image.tobytes(surface, "RGBA", True)
123c123
<         string = pygame.image.tostring(surface, "RGB", True)
---
>         string = pygame.image.tobytes(surface, "RGB", True)