[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#870573: grap: please make the build reproducible



Source: grap
Version: 1.45-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: uname
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed
that grap could not be built reproducibly as it includes the output
of `uname -sr` in the binary.

This results in a different checksum when built on, say i386 with
running a 686 kernel and running an an amd64 kernel (again, on
i386).

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb, Debian Project Leader
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-
--- a/debian/patches/reproducible_build.patch	1969-12-31 19:00:00.000000000 -0500
--- b/debian/patches/reproducible_build.patch	2017-08-02 20:05:34.337104563 -0400
@@ -0,0 +1,16 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2017-08-02
+
+--- grap-1.45.orig/grap_parse.cc
++++ grap-1.45/grap_parse.cc
+@@ -877,8 +877,7 @@ void usage() {
+ }
+ 
+ inline void version() {
+-    cout << "grap " << PACKAGE_VERSION << " compiled under " 
+-	 << OS_VERSION << endl;
++    cout << "grap " << PACKAGE_VERSION << endl;
+     cerr << "Fine comparsion limit: " << FINE_EPSILON << endl;
+     cerr << "Fine minimum value: " << FINE_MIN_DOUBLE << endl;
+     cerr << "Coarse comparsion limit: " << COARSE_EPSILON << endl;
--- a/debian/patches/series	1969-12-31 19:00:00.000000000 -0500
--- b/debian/patches/series	2017-08-02 20:05:33.233096268 -0400
@@ -0,0 +1 @@
+reproducible_build.patch

Reply to: