[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#853957: mpage FTCBFS: make install strips with the build architecture strip



On Thu, Feb 02, 2017 at 04:14:08PM +0200, Adrian Bunk wrote:
> On Thu, Feb 02, 2017 at 01:59:40PM +0100, Helmut Grohne wrote:
> >...
> > +-	install -s -m 755 -o root -g root mpage$(E) $(DESTDIR)/usr/bin
> > ++	$(INSTALL) -s -m 755 -o root -g root mpage$(E) $(DESTDIR)/usr/bin
> >...
> 
> Wouldn't just removing the -s here be the oneliner change to fix the
> whole bug?

>From a Debian pov, yes. My reasoning for not just removing it here is
that it seemed to be a deliberate upstream choice. Thus removing it
would make the patch non-upstreamable. The indirection however should be
less controversial.

Helmut


Reply to: