[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#623340: marked as done (libunac1: Type error in unac.c causes segfault)

Your message dated Mon, 6 Nov 2017 18:47:46 +0100
with message-id <01dcaab4-36e9-7174-0cc1-536f8b668f81@debian.org>
and subject line Re: libunac1: Type error in unac.c causes segfault
has caused the Debian Bug report #623340,
regarding libunac1: Type error in unac.c causes segfault
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
623340: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=623340
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libunac1
Version: 1.8.0-2
Severity: normal
Tags: upstream patch

A function call in unac.c ought to use size_t rather than int. I think
this is the cause of a segfault I've been trying to track down in
flactag.

Patch attached.

Phil

-- System Information:
Debian Release: 6.0.1
  APT prefers stable
  APT policy: (700, 'stable'), (600, 'unstable'), (500, 'stable-updates')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.38-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages libunac1 depends on:
ii  libc6                         2.11.2-10  Embedded GNU C Library: Shared lib

libunac1 recommends no packages.

libunac1 suggests no packages.

-- no debconf information

--- unac.c-orig	2011-04-19 13:54:18.659570997 +0100
+++ unac.c	2011-04-19 13:45:46.165065548 +0100
@@ -13873,9 +13873,9 @@
     *out_lengthp = 0;
   } else {
     char* utf16 = 0;
-    int utf16_length = 0;
+    size_t utf16_length = 0;
     char* utf16_unaccented = 0;
-    int utf16_unaccented_length = 0;
+    size_t utf16_unaccented_length = 0;
   
     if(convert(charset, utf16be(), in, in_length, &utf16, &utf16_length) < 0) {
       return -1;

--- End Message ---
--- Begin Message --- 
This is already fixed in sid / stretch.

--- End Message ---
Reply to: