Bug#858178: uuidcdef: buffer overflow

[Chris West <solo-debianbugs@goeswhere.com>]

tags 858178 + patch
thanks

This is correctly diagnosing a buffer which is to small.
The length of data written to the buffer is always constant,
(20 bytes more than the length of the buffer), and not under
user control, so there is probably not a security problem here.

A patch, to increase the length of the buffer, is attached.

--- xplc-0.3.13.orig/uuid/bin/uuidgen.c
+++ xplc-0.3.13/uuid/bin/uuidgen.c
@@ -239,7 +239,7 @@ int parse_conf(int argc, char** argv, st
 
 
 typedef const char* (*uuid_output_fn_t)(const uuid_t);
-static char uuid_unparse_buf[60];
+static char uuid_unparse_buf[80];
 const char* uuid_unparse_x_(const uuid_t uuid) {
   /* This function implicitly trusts uuid_unparse. */
   unsigned int a, b, c, d, e, f, g, h, i, j, k;
@@ -249,7 +249,7 @@ const char* uuid_unparse_x_(const uuid_t
                "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",
                &a, &b, &c, &d, &e, &f, &g, &h, &i, &j, &k);
   if(ret != 11) {
-    uuid_unparse_buf[59] = '\0';
+    uuid_unparse_buf[79] = '\0';
     fprintf(stderr,
             "%s: libuuid error at %s:%d\n", program, __FILE__, __LINE__);
     fprintf(stderr,