Bug#861443: ora2pg: please make the build reproducible

[Niels Thykier <niels@thykier.net>]

Control: tags -1 moreinfo

On Sat, 29 Apr 2017 09:08:22 +0100 Chris Lamb <lamby@debian.org> wrote:
> Source: ora2pg
> Version: 18.0-1
> Severity: wishlist
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: randomness
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0], we noticed
> that ora2pg could not be built reproducibly.
> 
> This is because it encodes the build process's current PID in the
> default configuration file.
> 
> 
> Patch attached.
> 
>  [0] https://reproducible-builds.org/
> 
> 
> Regards,
> 
> -- 
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      lamby@debian.org / chris-lamb.co.uk
>        `-

Hi Chris,

I suspect your patch is wrong because the original code is wrong as well.

$$ in postgres SQL is (often?) used to delimit the definition of
triggers and functions.  Therefore, I think you rather want the $$ to be
literal $$ in the config file rather than a ("random") number.

Thanks,
~Niels