[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#848917: nautic FTBFS on architectures where char is unsigned: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]



Control: tags -1 patch

Hi

The attached patch fixes more narrowing conversions with GCC 6 on architectures where char is unsigned by default.

Regards
Graham

Description: Fix more narrowing conversions with GCC 6
 Needed for architectures where char is unsigned by default
Bug-Debian: https://bugs.debian.org/848917
Author: Graham Inggs <ginggs@debian.org>
Last-Update: 2017-01-10
--- a/plant.h
+++ b/plant.h
@@ -30,7 +30,7 @@
   char maxargs;
   char max_harmonic[NARGS];
   char max_power_of_t;
-  char  *arg_tbl;
+  signed char  *arg_tbl;
   void  *lon_tbl;
   void  *lat_tbl;
   void  *rad_tbl;
@@ -1531,7 +1531,7 @@
          3,        13,
 
 };
-static char  args[] = {
+static signed char  args[] = {
   0,  3,
   3,  4,  3, -8,  4,  3,  5,  1,
   2,  2,  5, -5,  6,  2,
@@ -4393,7 +4393,7 @@
 
 };
 
-static char  argsm[] = {
+static signed char  argsm[] = {
   0,  3,
   3,  4,  3, -8,  4,  3,  5,  1,
   2,  2,  5, -5,  6,  2,
@@ -5760,7 +5760,7 @@
          0,       119,
 
 };
-static char  argsl[] = {
+static signed char  argsl[] = {
   0,  1,
   3,  1, 10,  1, 12, -1, 11,  1,
   4,  2, 10,  2, 12, -1, 13, -1, 11,  0,
@@ -7455,7 +7455,7 @@
 
 };
 /* Mars*/
-static char  argsmr[] = {
+static signed char  argsmr[] = {
   0,  4,
   3,  4,  3, -8,  4,  3,  5,  2,
   3,  5,  2, -6,  3, -4,  4,  0,
@@ -8347,7 +8347,7 @@
 
 };
 
-static char  argsv[] = {
+static signed char  argsv[] = {
   0,  3,
   2,  2,  5, -5,  6,  0,
   3,  2,  2,  1,  3, -8,  4,  0,
@@ -9500,7 +9500,7 @@
 
 };
 
-static char  argsj[] = {
+static signed char  argsj[] = {
   0,  6,
   3,  2,  5, -6,  6,  3,  7,  0,
   2,  2,  5, -5,  6,  6,
@@ -11116,7 +11116,7 @@
 
 };
 
-static char argsst[] = {
+static signed char argsst[] = {
   0,  7,
   3,  2,  5, -6,  6,  3,  7,  0,
   2,  2,  5, -5,  6,  5,
--- a/src/starpos.cpp
+++ b/src/starpos.cpp
@@ -2155,7 +2155,7 @@
 	  char *p;
 	#else
 	#ifdef __STDC__
-	   char *p;
+	   signed char *p;
 	#else
 	  char *p;
 	#endif
@@ -2324,7 +2324,7 @@
   char *p;
 #else
 #ifdef __STDC__
-   char *p;
+   signed char *p;
 #else
   char *p;
 #endif
@@ -2476,7 +2476,7 @@
   char *p;
 #else
 #ifdef __STDC__
-   char *p;
+   signed char *p;
 #else
   char *p;
 #endif
@@ -2593,7 +2593,7 @@
   char *p;
 #else
 #ifdef __STDC__
-   char *p;
+   signed char *p;
 #else
   char *p;
 #endif

Reply to: