[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#774807: marked as done (Fix broken Check_installed function)



Your message dated Fri, 02 Dec 2016 22:49:02 +0000
with message-id <E1cCwda-000EaI-OS@fasolo.debian.org>
and subject line Bug#774807: fixed in live-build 1:20161202
has caused the Debian Bug report #774807,
regarding Fix broken Check_installed function
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
774807: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=774807
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: live-build
Version: 4.0.4-1
Tags: patch

If checking against the host, whether through 'host' being specified (in
5.x), or LB_BUILD_WITH_CHROOT=false, and if dpkg-query is installed on
the host, the dpkg-query check is done against chroot, instead of the host.

This is so with v4.0.4-1, and also with 5.x, even after the improvement
in 5.x to improve host checking capabilities here.
commit b40a90fa9e56f070c677de2262caabf18e94ce59
Author: jnqnfe <jnqnfe@gmail.com>
Date:   Wed Jan 7 19:36:48 2015 +0000

    Fix Check_installed function when checking against host

diff --git a/functions/packages.sh b/functions/packages.sh
index 477d337..7e62daf 100755
--- a/functions/packages.sh
+++ b/functions/packages.sh
@@ -21,7 +21,7 @@ Check_package ()
 			_LB_PACKAGES="${_LB_PACKAGES} ${PACKAGE}"
 			;;
 
-		2)
+		2|3)
 			Echo_error "You need to install %s on your host system." "${PACKAGE}"
 			exit 1
 			;;
@@ -63,8 +63,9 @@ Remove_package ()
 # Check_installed
 # uses as return value global var INSTALL_STATUS
 # INSTALL_STATUS : 0 if package is installed
-#                  1 if package isn't installed and we're in an apt managed system
-#                  2 if package isn't installed and we aren't in an apt managed system
+#                  1 if package isn't installed in chroot
+#                  2 if package isn't installed in host
+#                  3 if package isn't installed in host, and host is not an apt managed system
 Check_installed ()
 {
 	CHROOT="${1}"
@@ -82,16 +83,16 @@ Check_installed ()
 	else
 		if which dpkg-query > /dev/null 2>&1
 		then
-			if Chroot chroot "dpkg-query -s ${PACKAGE}" 2> /dev/null | grep -qs "Status: install"
+			if dpkg-query -s ${PACKAGE} 2> /dev/null | grep -qs "Status: install"
 			then
 				INSTALL_STATUS=0
 			else
-				INSTALL_STATUS=1
+				INSTALL_STATUS=2
 			fi
 		else
 			if [ ! -e "${FILE}" ]
 			then
-				INSTALL_STATUS=2
+				INSTALL_STATUS=3
 			else
 				INSTALL_STATUS=0
 			fi

--- End Message ---
--- Begin Message ---
Source: live-build
Source-Version: 1:20161202

We believe that the bug you reported is fixed in the latest version of
live-build, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 774807@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Raphaël Hertzog <hertzog@debian.org> (supplier of updated live-build package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 02 Dec 2016 23:33:45 +0100
Source: live-build
Binary: live-build
Architecture: source
Version: 1:20161202
Distribution: unstable
Urgency: medium
Maintainer: Debian Live <debian-live@lists.debian.org>
Changed-By: Raphaël Hertzog <hertzog@debian.org>
Description:
 live-build - Live System Build Components
Closes: 731709 773775 773833 774730 774807 775989 790033 801379 801712 806782 808048 809699 816204 818916 831379 832998
Changes:
 live-build (1:20161202) unstable; urgency=medium
 .
   [ Raphaël Hertzog ]
   * Officially adopt the package. Closes: #808048
   * Better handle empty package lists.
   * Drop ixp4xx from available armel flavors, the image has been gone since
     linux 3.17.
   * Add symlinks for libgpl.c32 and libmenu.c32 which are required by
     the "Hardware Detection Tool (HDT)" menu entry that live-build adds
     in the advanced menu.
   * Add EFI boot support with grub-efi, thanks to Adrian Gibanel Lopez.
     Closes: #731709
   * Fix usage of config/packages.chroot/*.deb that has been broken by the
     switch to GnuPG2 by default by no longer using GnuPG but relying
     on APT's trusted=yes attribute instead.
     Thus we no longer have remaining key in /etc/apt/trusted.gpg
     after building. Closes: #816204
   * Try to reuse /isolinux/splash.png in default grub configuration.
   * Drop debian/source/{local-options,options} as they are no longer needed.
   * Pass components to debootstrap --second-stage. Closes: #806782
     Thanks to Sjoerd Simons <sjoerd.simons@collabora.co.uk> for the patch.
   * Fix behaviour of (undocumented) "#nif" conditional test. Closes: #801379
     Thanks to Erik Cumps <erik.cumps@esaturnus.com> for the patch.
   * Export SOURCE_DATE_EPOCH when running chroot commands. Closes: #832998
     Thanks to Chris Lamb <lamby@debian.org> for the patch.
   * Set xorriso's "modification time" to SOURCE_DATE_EPOCH. Closes: #831379
     Thanks to Chris Lamb <lamby@debian.org> for the patch.
   * Support “lb config --debootstrap-script <script>” to use an alternate
     bootstrap script when running debootstrap. Thanks to Sjoerd Simons
     <sjoerd@debian.org> for the initial patch. Closes: #790033
   * Manual pages updates by jnqnfe. Closes: #774730
   * Drop left-over translation files for removed lb_testroot command.
   * Get rid of useless bootstrap_archive-keys script. Closes: #773775
   * Drop an optimization in chroot_archives that has undesired side-effects.
     Thanks to jnqnfe for the patch. Closes: #775989
   * Drop gpgv and debian-keyring from Suggests.
   * Fix Check_installed function when checking against host. Thanks to jnqnfe
     for the report. Closes: #774807
   * Bump debhelper compat level to 10.
   * Bump Standards-Version to 3.9.8.
   * Use a grub theme that integrates reasonably well with the current
     background picture.
   * Default for LB_UNION_FILESYSTEM is now "overlay" just like in live-boot.
   * Update the way we generate the version of live-build that is displayed by
     lb --version.
   * Instead of renaming kernel for syslinux, create hardlinks.
   * Simplify grub configuration code to use only long kernel names. Put
     advanced options in a submenu. Use distro-agnostic labels.
 .
   [ Kristian Klausen ]
   * Include ext{3,4} journal size when calculating image size. Closes: #801712
   * Switch d-i.debian.org URIs from http to https. Closes: #809699
   * Fix typo in binary_syslinux. Closes: #818916
   * Correct syslinux/extlinux mbr.bin path. Closes: #773833
Checksums-Sha1:
 e783fa6b0d05665b6f469a129c9879fd09bd7eaa 1369 live-build_20161202.dsc
 aafba09d63b5272b406faeb78f29c0693ad2403f 352376 live-build_20161202.tar.xz
Checksums-Sha256:
 794d5ac54770ee627c1e65c3a97db626f426d3e0414045fa7f4ee34e888b3ecc 1369 live-build_20161202.dsc
 e3930f826ecd3a3b8b49df56f7c130c087c9268fe8dda16aa340be15b1c9b148 352376 live-build_20161202.tar.xz
Files:
 b0b7bc9164340ae43a2fe2654692fa29 1369 misc optional live-build_20161202.dsc
 39cb06ac14afe4e6c8de32aeeac6e08a 352376 misc optional live-build_20161202.tar.xz

-----BEGIN PGP SIGNATURE-----
Comment: Signed by Raphael Hertzog

iQEzBAEBCgAdFiEE1823g1EQnhJ1LsbSA4gdq+vCmrkFAlhB9vcACgkQA4gdq+vC
mrnfbQf+K+CbLMaL6+aCMvN7UI9JtDOvB6K9wu8dDnNUNLJcRqgvdx+03DfU08oD
X3UhZWJGhxVUvVIM+HSt/JXi9KKCfOxG4WnCiEzj1ewYihjgD2SICh1OrsL/SswS
dCwNAPGJYfWOFwvESBbf3Q6XdVuKqj17ImjICtYfsirD/1vuQU4bCepi1ZJShXrs
RdDpeVbzsti4hJlMax9xTxmmmercVq2fm81X5CHSnGh/IRIc77akJH5D+vRhZSM1
aAEQANEzof4TySnk7I62QJn0ik/Uykuk2w8DoRH6f3fZCOxagnm0bHW9WzhP6Zu/
dtD4kG3TrZAikkCeStx6hxGZxhFD8A==
=vy9F
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: