Bug#845324: FTBFS: /bin/sh: 1: emacs: not found

[Eriberto <eriberto@eriberto.pro.br>]

Hi Neil,

2016-11-22 16:59 GMT-02:00 Neil Williams <codehelp@debian.org>:
> severity 845324 normal
> tag 845324 + unreproducible
> tag 845324 + moreinfo
> thanks
>
> On Tue, 22 Nov 2016 10:52:27 -0200
> Joao Eriberto Mota Filho <eriberto@debian.org> wrote:
>
>> Package: bhl
>> Version: 1.7.3-3
>> Severity: serious
>> Tags: newcomer
>> Justification: fails to build from source
>
> It does build in sbuild. Build log attached.
>
> The package also builds in the reproduciblility tests.
>
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/bhl.html
>
>> Hi,
>>
>> The package is 'all' and always was sent already built. It needs
>> emacs to build from source. Please, add 'emacs' as build dependency.
>
> It's certainly needed as a Depends - I don't see that it needs to be Build-Depends.
>
> debdiff /var/cache/apt/archives/bhl_1.7.3-3_all.deb bhl_1.7.3-3_all.deb
> File lists identical (after any substitutions)
>
> Control files: lines which differ (wdiff format)
> ------------------------------------------------
> Installed-Size: [-243-] {+199+}


Hum... You are right...

I am sponsoring this package as QA upload. The d/rules was migrated to
new format. So, this rules is doing a 'make' when running
dh_auto_build. The new d/rules:

#!/usr/bin/make -f
#export DH_VERBOSE=1

%:
        dh $@

override_dh_auto_build:
        $(MAKE) info
        dh_auto_build

The result:

dh_auto_build
        make -j8
make[2]: Entering directory '/tmp/20161122/bhl/bhl-1.7.3'
Compiling EL files of BHL ...
PLEASE IGNORE WARNINGS IF DISPLAYED. TAKE IT EASY!
emacs -batch -q -no-site-file --eval "(byte-compile-file \"bhl.el\")"
/bin/sh: 1: emacs: not found
Makefile:91: recipe for target 'el' failed
make[2]: *** [el] Error 127


You can reproduce running 'make' in upstream place. I read now about
byte compiled and am think that it is not needed. Can you give a
light? If not needed, we can use:

#!/usr/bin/make -f
#export DH_VERBOSE=1

%:
        dh $@

override_dh_auto_build:
        $(MAKE) info

override_dh_auto_install:


This rules needn't emacs as build dependency.

Thanks for your help.

Regards,

Eriberto