[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)



El 25/08/16 a las 15:36, Raphael Hertzog escribió:
Hello Adrian,

On Tue, 16 Aug 2016, adrian15 wrote:
Kristian Klausen thinks is a good idea to wait for your tests.
So your feedback is welcome.

I just built a test Kali image with your patch applied. It works:
I can boot the live system in UEFI mode.

Great!

> But I also saw a few problems:
- the grub menu looks ugly (see attached picture), it's in plain
   text mode and the background is not even uniform (sometimes blue,
   sometimes black)
That's how the grub-pc menu (BIOS) shows currently in live-build.

- there are no menu entries to start debian-installer even though
   I built my image with "--debian-installer live"

There were not such entries in the isolinux menu (BIOS). I already commented such incongruence when I submitted my loopback patch but Daniel (or irl maybe?. It was around the time dba quitted the project) agreed to merge my code.

In my commit:
https://anonscm.debian.org/cgit/debian-live/live-build.git/commit/?id=b6771e736022d31b0cb53c552a0f7a42a1028a09

I already said:

Compared to binary_grub2 script I have removed the installation
entries because I did not see any of them in binary_syslinux.

Can you explain to me why such Installation entries are not available in binary_syslinux?
Maybe they should be put there also?

- the menu entries hardcode "Debian GNU/Linux" as name of the project,
   in the default syslinux configuration the entries are agnostic as in
   "Live (@FLAVOUR@)".
That @FLAVOUR@ is from Debian's live-build?

That was not the case for grub2 (BIOS) files.

You have:

https://anonscm.debian.org/cgit/debian-live/live-build.git/tree/share/bootloaders/grub-pc/grub.cfg?id=489a09ba92328cef846598a15329e9ff91519e3c

LINUX_LIVE
and
LINUX_INSTALL

strings which get replaced by the grub-pc script.

https://anonscm.debian.org/cgit/debian-live/live-build.git/tree/scripts/build/binary_grub-pc?id=489a09ba92328cef846598a15329e9ff91519e3c

In that case 'Debian Live' is hardcoded.


I guess that some of those issues are not due to your changes, they
are probably longstanding issues in the generic grub code but still
it would be nice to have this fixed to have a more consistent experience
between grub and syslinux.

Well, there are some possible solutions to this problem:

1. Try to reuse some code from jnqnfe. He did quite some work on improving bootloaders design which I don't think got into GIT: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775322 .

2. Try to reuse the debian-cd scripts which try to convert syslinux cfg files into grub ones (including the design).

Here:

https://anonscm.debian.org/cgit/debian-cd/debian-cd.git/tree/tools/boot/jessie/parse_isolinux

Not sure if this is the correct version to use but be warned that Sledge himself warns us that it's not pretty.

3. Commit the patch as is and later on add more patches on the minimal set needed for prettyfing this.

I advocate for commiting the patch as soon as possible so that I can ask new commits such as the Suchanek's ' "support multiple kernel versions with same flavour" to be reworked on over my uefi support.

adrian15
--
Support free software. Donate to Super Grub Disk. Apoya el software libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/


Reply to: