Bug#731709: grub-efi UEFI support based on debian-cd work complete (repos)
On 21 March 2016 at 23:06, adrian15 <adrian15sgd@gmail.com> wrote:
> El 21/03/16 a las 22:19, Michal Suchanek escribió:
>
>> The bootloader support in live-build is limited. With your patches it
>> becomes wrong. eg. compatibility of bootloader with selected
>> filesystem and image type is only checked for first bootloader and EFI
>> support is added only when grub-efi extra bootloader but not when it
>> is the first bootloader.
>>
>> This is not fixed by renaming the variables.
>
>
> Ok. So I recognise that my patch:
>
> * Adds a limited support of UEFI only available when it's used as an extra
> bootloader
> * Does not check compatibility with selected filesystem in the extra
> bootloader because it blindly relies on selected filesystem selected in
> first bootloader being compatible with the extra bootloader too.
> * It does not work for hdd binaries (only iso binaries)
>
> and it does in addition to what live-build already did.
No, it does not.
live-build only installed bootloader which was compatible with
selected filesystem and image type which is no longer true with your
patch. In fact, if I choose grub-efi as first bootloader the efi
support is not added and compatibility of any extra bootloaders with
the filesystem chosen is not checked so the image may be completely
unbootable.
So please consider either
1) fixing your current patch so there is no primary or first
bootloader and all installed bootloaders are equal
2) don't pretend you add support for multiple bootloaders when you are
not wiling to do so and just and some option like --bolt-on-grub-efi
which installs grub-efi if image type and filesystem is compatible
with grub-efi and fails the build otherwise
BTW it has been pointed out already that -eltorito-alt-boot is just
separator that starts new boot entry so there are no special
secondary/extra bootloader options. Any bootloader can be
first/second/third/whatever.
Thanks
Michal
Reply to: