Bug#818916: live-build: Wrong version extracted from os-release in binary-syslinux
Package: live-build
Version: 5.0~a11-1
Severity: minor
Dear Maintainer,
* What led up to the situation?
I was trying to use @VERSION@ string in splash.svg.
* What exactly did you do (or not do) that was effective (or
ineffective)?
I used @VERSION@ string in splash.svg.
* What was the outcome of this action?
@VERSION@ was replaced by: 5.0~a11-1 which it's the live-build package
version.
* What outcome did you expect instead?
@VERSION@ should have been replaced by: 8 (The version read from
os-release for
my build) which it's the distro, in this case Debian, version.
Additional information. I attach a trivial patch which solves the problem.
-- System Information:
Debian Release: 8.2
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
>From b516d2defaeda72a03400dbd1a17b91d6bca7e31 Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez <adrian.gibanel@btactic.com>
Date: Mon, 21 Mar 2016 18:44:38 +0100
Subject: [PATCH] @VERSION@ now its equal to VERSION_ID variable. Fixes a typo.
---
scripts/build/binary_syslinux | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/build/binary_syslinux b/scripts/build/binary_syslinux
index 024b563..66c14a0 100755
--- a/scripts/build/binary_syslinux
+++ b/scripts/build/binary_syslinux
@@ -248,7 +248,7 @@ then
_VERSION="$(. chroot/etc/os-release && echo ${VERSION_ID})"
fi
-_VERSION="${VERSION:-none}"
+_VERSION="${_VERSION:-none}"
_DISTRIBUTION="${LB_DISTRIBUTION}"
_ARCHITECTURE="${LB_ARCHITECTURES}"
--
2.1.4
Reply to: