[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#824592: marked as done (twitter-bootstrap: wrong copyright formatting when using bash)

Your message dated Sat, 01 Oct 2016 23:29:01 +0000
with message-id <E1bqTiH-0001su-Hd@franck.debian.org>
and subject line Bug#824592: fixed in twitter-bootstrap 2.0.2+dfsg-10
has caused the Debian Bug report #824592,
regarding twitter-bootstrap: wrong copyright formatting when using bash
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
824592: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824592
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: twitter-bootstrap
Version: 2.0.2+dfsg-9
Severity: minor
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: environment
X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org

Dear Maintainer,

While working on the “reproducible builds” effort [1], we have noticed
that 'twitter-bootstrap' could not be built reproducibly [2].

When using the shell bash, echo does not expand "\n" in the copyright
string, leading to an unexpected result.
This can be fixed by using printf instead of echo, as illustrated by the
attached patch.

Once applied, twitter-bootstrap can be built reproducibly in our current
experimental framework.

Regards,
Alexis Bienvenüe.

 [1] https://wiki.debian.org/ReproducibleBuilds
 [2]
https://reproducible.debian.net/rb-pkg/testing/amd64/twitter-bootstrap.html








diff -Nru twitter-bootstrap-2.0.2+dfsg/debian/patches/06-use-printf-instead-of-echo.patch twitter-bootstrap-2.0.2+dfsg/debian/patches/06-use-printf-instead-of-echo.patch
--- twitter-bootstrap-2.0.2+dfsg/debian/patches/06-use-printf-instead-of-echo.patch	1970-01-01 01:00:00.000000000 +0100
+++ twitter-bootstrap-2.0.2+dfsg/debian/patches/06-use-printf-instead-of-echo.patch	2016-05-17 22:06:16.000000000 +0200
@@ -0,0 +1,17 @@
+Description: Use printf instead of echo
+ "\n" can be expanded or not by echo, depending on the shell used.
+ So using printf instead of echo is more reliable.
+Author: Alexis Bienvenüe <pado@passoire.fr>
+Index: twitter-bootstrap-2.0.2+dfsg/Makefile
+===================================================================
+--- twitter-bootstrap-2.0.2+dfsg.orig/Makefile
++++ twitter-bootstrap-2.0.2+dfsg/Makefile
+@@ -35,7 +35,7 @@ bootstrap:
+ 	lessc --compress ${BOOTSTRAP_RESPONSIVE_LESS} > bootstrap/css/bootstrap-responsive.min.css
+ 	cat js/bootstrap-transition.js js/bootstrap-alert.js js/bootstrap-button.js js/bootstrap-carousel.js js/bootstrap-collapse.js js/bootstrap-dropdown.js js/bootstrap-modal.js js/bootstrap-tooltip.js js/bootstrap-popover.js js/bootstrap-scrollspy.js js/bootstrap-tab.js js/bootstrap-typeahead.js > bootstrap/js/bootstrap.js
+ 	uglifyjs bootstrap/js/bootstrap.js > bootstrap/js/bootstrap.min.tmp.js
+-	echo "/**\n* Bootstrap.js by @fat & @mdo\n* Copyright 2012 Twitter, Inc.\n* http://www.apache.org/licenses/LICENSE-2.0.txt\n*/"; > bootstrap/js/copyright.js
++	printf "/**\n* Bootstrap.js by @fat & @mdo\n* Copyright 2012 Twitter, Inc.\n* http://www.apache.org/licenses/LICENSE-2.0.txt\n*/\n"; > bootstrap/js/copyright.js
+ 	cat bootstrap/js/copyright.js bootstrap/js/bootstrap.min.tmp.js > bootstrap/js/bootstrap.min.js
+ 	rm bootstrap/js/copyright.js bootstrap/js/bootstrap.min.tmp.js
+ 
diff -Nru twitter-bootstrap-2.0.2+dfsg/debian/patches/series twitter-bootstrap-2.0.2+dfsg/debian/patches/series
--- twitter-bootstrap-2.0.2+dfsg/debian/patches/series	2015-09-25 15:00:00.000000000 +0200
+++ twitter-bootstrap-2.0.2+dfsg/debian/patches/series	2016-05-17 22:06:56.000000000 +0200
@@ -3,3 +3,4 @@
 03-use-nodejs-command.patch
 04-build-with-node-1.4.2.patch
 05-drop-nc-from-uglifyjs.patch
+06-use-printf-instead-of-echo.patch

--- End Message ---
--- Begin Message --- 
Source: twitter-bootstrap
Source-Version: 2.0.2+dfsg-10

We believe that the bug you reported is fixed in the latest version of
twitter-bootstrap, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 824592@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated twitter-bootstrap package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 01 Oct 2016 23:28:37 +0100
Source: twitter-bootstrap
Binary: libjs-twitter-bootstrap
Architecture: source all
Version: 2.0.2+dfsg-10
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 libjs-twitter-bootstrap - HTML, CSS and JS toolkit from Twitter
Closes: 824592
Changes:
 twitter-bootstrap (2.0.2+dfsg-10) unstable; urgency=medium
 .
   * QA upload.
   * Fix wrong copyright formatting when using bash. Thanks to Alexis Bienvenüe
     <pado@passoire.fr> for the patch. (Closes: #824592)
   * Bump Standards-Version to 3.9.8.
Checksums-Sha1:
 703d3c4a044cbec11097fae31f5a5b096087c3b3 1875 twitter-bootstrap_2.0.2+dfsg-10.dsc
 d81910f3f29c01c5eca3ce0ced202d9707d40305 664928 twitter-bootstrap_2.0.2+dfsg.orig.tar.xz
 ecd7046f1e1b2f6d6093661924d88d01449aee28 46596 twitter-bootstrap_2.0.2+dfsg-10.debian.tar.xz
 476d2a9397ed414f27b0b6a0c5ce717e6b0a9bd9 98802 libjs-twitter-bootstrap_2.0.2+dfsg-10_all.deb
Checksums-Sha256:
 b7aeb7fdc35eb6abbfbc2f2e80cddac35213c0aca8ede20d2a1590e312f18ca5 1875 twitter-bootstrap_2.0.2+dfsg-10.dsc
 8e5d9fdf3aa1fa7cd74c8c8913df7cd9bea56dd8f442d75fc31972e244ac5ed5 664928 twitter-bootstrap_2.0.2+dfsg.orig.tar.xz
 c5b64d2fbceaee8c5543c9640132260fdb254b40b55b3e27b6d29de7a80f00cb 46596 twitter-bootstrap_2.0.2+dfsg-10.debian.tar.xz
 42b902d5af3f95d2d6906d73f918378c047e4730710b68a999346a095da7c5b5 98802 libjs-twitter-bootstrap_2.0.2+dfsg-10_all.deb
Files:
 4dfac95b488b10593357ac7439c027f2 1875 oldlibs optional twitter-bootstrap_2.0.2+dfsg-10.dsc
 70fbaea9494ac9e572fad651bdeb83d9 664928 oldlibs optional twitter-bootstrap_2.0.2+dfsg.orig.tar.xz
 0209aa6b519351ad655579ab0ce4ba34 46596 oldlibs optional twitter-bootstrap_2.0.2+dfsg-10.debian.tar.xz
 54524f835acf9d470599ac0778c4e527 98802 oldlibs optional libjs-twitter-bootstrap_2.0.2+dfsg-10_all.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJX8DldAAoJEB6VPifUMR5Yb90P/2rV/V6RWiHkbiK6zXveiDid
xGrBPOPBQa3qZ2pw7aEYoNajCP7yOJv3Y3Z6KO5UpckPjWl7RxL3qKx9VPHNzSO0
jbYdHyu/gWn9kgN0/4SsmX7w3jy12Y9Wtdt5/aPqJ+mKlekxZGXoCXwO7nLxWnvE
VbOSs3JsEsGWhBPlIrQgfOk0Kw75ZBnkgPkyxBBwBYhKXrQ0xFTFPC1K44BD7mub
J5q6hjd7ENe21p3lmztwWtwlxFe51mNUBMtHocUh6fL5GaDLF5js0kGoS3bg6Yj2
pKgfOpx7TVS+gpWAPbI3XAyosyxWcKwWvE2hhYDQDaLV7YT10vX96HHu6WLCL0QP
4RDEd2RuPQM8RBDiiIrHFy4Gz/rf00q9nvjngKGCiK1t3hijICT6cne7VhNMhXbO
orWjr1Hx4FD3Eu/igoE2Y9E24eFqo2JPhnHe0QB/uPd/s1ushzA7RPtNFo9gxrDh
J14Fr5VBAGyyd1/ZQriJ7kPXHN8y6oRtYUYH74esPTd/+xIIdxF8BhdS4t6bYcr0
DRTxdfUUJvZcQYOu0ru/Pl2wv/YxYmHE7xlNCH36Js8bsepcD5cvzJ41b9kilwkh
ubPC5TLzpwSiDccydZRcM8aJP81N+KNGI1B0lsw7aCiP+3yy4QviBHol4oQsyjH9
Maa+kLoJDjuaKqkAnHTk
=2FrH
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: