Bug#812168: skyeye: FTBFS using clang instead of gcc

[Arthur Marble <arthur@info9.net>]

Package: skyeye
Severity: minor
Tags: patch
User: pkg-llvm-team@lists.alioth.debian.org
Usertags: clang-ftbfs

Hello,

Using the rebuild infrastructure, your package fails to build with clang
(instead of gcc).

Detected this kind of error:
http://clang.debian.net/status.php?version=3.6.0&key=FUNCTION_RETURNS_VALUE

Full build log is available here:
http://clang.debian.net/logs/2015-03-25/skyeye_1.2.5-4_unstable_clang.log

I have attached a patch to fix this error.

Regards,
--Arthur Marble


-- System Information:
Debian Release: sid (unstable)
Architecture: amd64 (x86_64)
Kernel: Linux 4.2.0-1-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE="en_US.UTF-8"
Shell: /bin/sh linked to /bin/dash
Compiler: Debian clang version 3.6.2-3 (based on LLVM 3.6.2)

--- a/arch/arm/common/armsupp.c
+++ b/arch/arm/common/armsupp.c
@@ -693,7 +693,7 @@
 		//chy 2004-07-19 should fix in the future????!!!!
 		//printf("SKYEYE ARMul_MRC,NOT ALLOWed UndefInstr  CPnum is %x, instr %x\n",CPNum, instr);
 		ARMul_UndefInstr (state, instr);
-		return;
+		return 0;
 	}
 
 	cpab = (state->MRC[CPNum]) (state, ARMul_FIRST, instr, &result);
--- a/arch/bfin/mach/bf533_io.c
+++ b/arch/bfin/mach/bf533_io.c
@@ -864,7 +864,7 @@
 	default:
 		IO_ERR;
 	}
-	return;
+	return 0;
 
 }
 static bu32
@@ -883,7 +883,7 @@
 	default:
 		IO_ERR;
 	}
-	return;
+	return 0;
 
 }
 static void
--- a/arch/bfin/mach/bf537_io.c
+++ b/arch/bfin/mach/bf537_io.c
@@ -870,7 +870,7 @@
 	default:
 		IO_ERR;
 	}
-	return;
+	return 0;
 
 }
 static bu32
@@ -889,7 +889,7 @@
 	default:
 		IO_ERR;
 	}
-	return;
+	return 0;
 
 }
 static void
--- a/arch/coldfire/common/cf_arch_interface.c
+++ b/arch/coldfire/common/cf_arch_interface.c
@@ -41,7 +41,7 @@
 #include "skyeye_config.h"
 char Run_Exit = 0;
 
-SKYEYE_DBGR_DEFAULT_CHANNEL(run);
+/* SKYEYE_DBGR_DEFAULT_CHANNEL(run); // Unused macro? */
 
 static int stop_now = 0;
 
--- a/arch/coldfire/common/exception.c
+++ b/arch/coldfire/common/exception.c
@@ -10,7 +10,7 @@
 
 #include "coldfire.h"
 
-SKYEYE_DBGR_DEFAULT_CHANNEL(exception);
+/* SKYEYE_DBGR_DEFAULT_CHANNEL(exception);  // Unused macro? */
 
 static short exception_pending = 0;
 static unsigned int (*iack_func[8])(unsigned int interrupt_level)
--- a/arch/coldfire/common/i.c
+++ b/arch/coldfire/common/i.c
@@ -10,7 +10,7 @@
 #include "coldfire.h"
 
 
-SKYEYE_DBGR_DEFAULT_CHANNEL(i);
+/* SKYEYE_DBGR_DEFAULT_CHANNEL(i);  // Unused Macro? */
 
 #define MALLOC_STEP 16
 struct _Instruction *Instruction = NULL;
--- a/arch/coldfire/common/handlers.c
+++ b/arch/coldfire/common/handlers.c
@@ -11,7 +11,7 @@
 
 #include "coldfire.h"
 
-SKYEYE_DBGR_DEFAULT_CHANNEL(handlers);
+/* SKYEYE_DBGR_DEFAULT_CHANNEL(handlers);  // Unused macro? */
 
 
 void SR_Set(short Instr, int Source, int Destination, int Result)
--- a/arch/coldfire/common/ram.c
+++ b/arch/coldfire/common/ram.c
@@ -15,7 +15,7 @@
 /*#define SKYEYE_DBGR_OFF*/
 #include "coldfire.h"
 
-SKYEYE_DBGR_DEFAULT_CHANNEL(ram);
+/* SKYEYE_DBGR_DEFAULT_CHANNEL(ram);  // Unused macro? */
 
 void ram_init(void);
 static void ram_setup(struct _memory_segment *s);
--- a/arch/coldfire/common/memory.c
+++ b/arch/coldfire/common/memory.c
@@ -31,7 +31,7 @@
 /* memory core copy with values used when reset */
 static struct _memory_core memory_core_reset_values;
 
-TRACER_DEFAULT_CHANNEL(memory);
+TRACER_DEFAULT_CHANNEL(char memory);
 
 
 static struct _memory_module *memory_module = NULL;
--- a/arch/coldfire/instruction/i_div.c
+++ b/arch/coldfire/instruction/i_div.c
@@ -63,7 +63,7 @@
 
 int DIVSTime[8]={18, 20, 20, 20, 20, -1, -1, -1};
 
-SKYEYE_DBGR_DEFAULT_CHANNEL(i_div);
+/* SKYEYE_DBGR_DEFAULT_CHANNEL(i_div);  // Unused macro? */
 
 
 #define DIV_W_REGISTER(word) 	(((word)&0x0e00) >> 9)
--- a/arch/mips/common/dcache.c
+++ b/arch/mips/common/dcache.c
@@ -242,7 +242,8 @@
         int i;
 
         // A direct memory access.
-        return mips_mem_read(pa, x, size);
+        mips_mem_read(pa, x, size);
+	return;
 }
 /* Store data to the virtual address (va). The address translation has already
  * been performed and the physical address is (pa). The coherency algorithm to
@@ -336,5 +337,6 @@
 store(MIPS_State* mstate, UInt32 data, VA va, PA pa, int size)          {
         UInt32 addr=bits(pa, 31, 0);                                    
         UInt32 x = data;                                                
-        return mips_mem_write(pa, &data, size);
+        mips_mem_write(pa, &data, size);
+	return;
 }
--- a/utils/debugger/ppc_regdefs.c
+++ b/utils/debugger/ppc_regdefs.c
@@ -96,7 +96,7 @@
 			case 69:
 				//XER = v;
 				gCPU.xer = v;
-				return;
+				break;
 			case 70:
 				//FPSCR = v;
 				gCPU.fpscr = v;