[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#766631: marked as done (FTBFS ppc64el: Remove deprecated SVID_SOURCE)

Your message dated Mon, 14 Dec 2015 09:43:33 +0000
with message-id <E1a8PfJ-00071i-MS@franck.debian.org>
and subject line Bug#766631: fixed in turnserver 0.7.3-4
has caused the Debian Bug report #766631,
regarding FTBFS ppc64el: Remove deprecated SVID_SOURCE
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
766631: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=766631
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: turnserver
Version: 0.7.3-2
Severity: critical
Tags: patch

At the moment, turnserver doesn't build on ppc64el platform with the following
error:

In file included from tls_peer.c:72:0:
/usr/include/netinet/tcp.h:89:11: error: duplicate member 'th_off'
  u_int8_t th_off:4;  /* data offset */
           ^
/usr/include/netinet/tcp.h:90:11: error: duplicate member 'th_x2'
  u_int8_t th_x2:4;  /* (unused) */

https://buildd.debian.org/status/fetch.php?pkg=turnserver&arch=ppc64el&ver=0.7.3-2&stamp=1410498176

That is because both path of the following are being executed:

 # if __BYTE_ORDER == __BIG_ENDIAN
         u_int8_t th_off:4;              /* data offset */
         u_int8_t th_x2:4;               /* (unused) */
 # endif
 # if __BYTE_ORDER == __LITTLE_ENDIAN
         u_int8_t th_x2:4;               /* (unused) */
         u_int8_t th_off:4;              /* data offset */
 # endif

This is because SVID_SOURCE is being used, and it is deprecated. The proper way
is to use _DEFAULT_SOURCE, which fixes the problem above.

Thanks
Breno

--- turnserver-0.7.3.orig/src/Makefile.am
+++ turnserver-0.7.3/src/Makefile.am
@@ -1,4 +1,4 @@
-AM_CFLAGS = -std=c99 -Wall -Wextra -Werror -Wstrict-prototypes -Wredundant-decls -Wshadow -pedantic -fno-strict-aliasing -D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=600 -O2 -D_SVID_SOURCE
+AM_CFLAGS = -std=c99 -Wall -Wextra -Werror -Wstrict-prototypes -Wredundant-decls -Wshadow -pedantic -fno-strict-aliasing -D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=600 -O2 -D_DEFAULT_SOURCE
 
 if ENABLE_DEBUG_BUILD
 AM_CFLAGS += -g 
--- turnserver-0.7.3.orig/src/Makefile.in
+++ turnserver-0.7.3/src/Makefile.in
@@ -288,7 +288,7 @@ top_srcdir = @top_srcdir@
 AM_CFLAGS = -std=c99 -Wall -Wextra -Werror -Wstrict-prototypes \
 	-Wredundant-decls -Wshadow -pedantic -fno-strict-aliasing \
 	-D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=600 -O2 \
-	-D_SVID_SOURCE $(am__append_1) $(am__append_2)
+	-D_DEFAULT_SOURCE $(am__append_1) $(am__append_2)
 INCLUDE = -I.
 noinst_HEADERS = turnserver.h \
 								 turn.h \

--- End Message ---
--- Begin Message --- 
Source: turnserver
Source-Version: 0.7.3-4

We believe that the bug you reported is fixed in the latest version of
turnserver, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 766631@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Beckmann <anbe@debian.org> (supplier of updated turnserver package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 14 Dec 2015 09:04:59 +0100
Source: turnserver
Binary: turnserver
Architecture: source
Version: 0.7.3-4
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Andreas Beckmann <anbe@debian.org>
Description:
 turnserver - server for ICE/STUN/TURN, NAT traversal for SIP and Jabber
Closes: 766631
Changes:
 turnserver (0.7.3-4) unstable; urgency=medium
 .
   * QA upload.
   * Switch from deprecated _SVID_SOURCE to _DEFAULT_SOURCE, fixing FTBFS on
     ppc* (any maybe more) architectures, thanks to Breno Leitao.
     (Closes: #766631)
   * Use canonical Vcs-* URLs.
Checksums-Sha1:
 f6cb757866fe451961b09535d0f3f09d2b65134f 1937 turnserver_0.7.3-4.dsc
 0f3fe8b922c440f964afbccca2990abedc7ca275 5580 turnserver_0.7.3-4.debian.tar.xz
Checksums-Sha256:
 b59daa9dc7c7f9d75f12c464d56bf1f8f52459d58928dd02e05d38c507982e1b 1937 turnserver_0.7.3-4.dsc
 5a92881527bed099cd27d0863bc8d2e4f8f2f155f97af357c1484cee1149861b 5580 turnserver_0.7.3-4.debian.tar.xz
Files:
 82d497e5bcc3dbf8c8685250b91eb969 1937 net extra turnserver_0.7.3-4.dsc
 de67b75ee0c1ba568c56d143986634af 5580 net extra turnserver_0.7.3-4.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWbnntAAoJEF+zP5NZ6e0IJTgP/jmBMtCyd7cSYBhHzhA2VynL
fSZbdljZr/thg+10qemsV5o9ZUk4HJ27bq0hzSyVQAMbIYqfOKpEUkDg5bZvePpb
h6XRPuKVys5deIyhLkHlj5EikWJnXwXm+qfxenVotM9I0E7Ud7IVrAfBFFaaGeFI
oa2ucHDcjHdTmHqZsW69LalH9WSsIXPWoA7I4xoiiU7T9Fl73n8VV6j9+/TrlDrP
KGKx5qUObuWH2Ps+shGV9YGZWBA+IS3NSKf/aqA7rUkEQMAJewRnI/l0sx47wWiT
VTwxiGbIK94yypx63/b2lSx6Av28eb+B2i13vowLmcuseybcS06IEpsNFzhRvXIJ
6QBnVOQG5CnSGY6n74fEwMb1Uv3vKXdS7L5xJMcTFBFkJkgfF6zucd4Jrr7dsicy
in3xdGnHmQcus2y7pdIXtXSa4T23DgJOXlhIe6UIRdjvMbeC9c5ce2xwfGLlRF1G
eob1y/uSC6Ch2R4lqbnNeAUBSrU6/XQ6qVQEFq1kTvstxlrywLb45ByxALnz6SR7
IqHhHGFo3vqhOCQukhqTBwuCJ5v1OFkx3Vbhhi4AzdkI9qtPPyUfrbILMX4fPCVo
QlOFtrwDDhIx6niLTNN/jCO+zIYF4dEKdr4qTxoLlL9msDoN3u38fsP4yJHisO0J
gKifAbuUkw13U1x7xbSS
=SHFC
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: