[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#797522: dnswalk: deprecated warnings



Package: dnswalk
Version: 2.0.2.dfsg.1-0.1
Severity: minor

Dear Maintainer,

on execution there are multiple warnings like "defined(@array) is deprecated
at"

>From perl-doc: "Use of defined on aggregates (hashes and arrays) is deprecated.
It used to report whether memory for that aggregate had ever been allocated.
This behavior may disappear in future versions of Perl. You should instead use
a simple test for size"
--- dnswalk	2015-08-31 10:34:27.000000000 +0200
+++ dnswalk_new	2015-08-31 10:41:15.886391098 +0200
@@ -56,9 +56,9 @@
     return unless $domain;
     print "Checking $domain\n";
     @subdoms=&doaxfr($domain);
-    &check_zone($domain) if (defined(@zone) && @zone);
+    &check_zone($domain) if (@zone);
     undef @zone;
-    return if (!(defined(@subdoms) && @subdoms));
+    return if (!@subdoms);
     @sortdoms = sort byhostname @subdoms;
     local ($subdom);
     if ($opt_r) {
@@ -84,7 +84,7 @@
 	my $res = new Net::DNS::Resolver;
 	$res->nameservers($server);
 	@zone=$res->axfr($domain);
-	unless (defined(@zone) && @zone) {
+	unless (@zone) {
 	    print STDERR "failed\n";
 		&printerr("FAIL",
 			"Zone transfer of $domain from $server failed: ".
@@ -104,7 +104,7 @@
         print STDERR "done.\n";
         last SERVER;
     } # foreach #
-    unless (defined(@zone) && @zone) {
+    unless (@zone) {
 	    &printerr("BAD","All zone transfer attempts of $domain failed!\n");
 	    return undef;
     }

Reply to: