[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#764992: dosfstools: successive runs of fsck -yvV show same error



Package: dosfstools
Version: 3.0.26-4
Followup-For: Bug #764992

This bug seems to be caused by uninitialised dir entry fields for the
root directory.
Valgrind shows 2 errors about "conditional jump or move depends on
uninitialised value"

Initialising the dir entry structure when constructing the root
directory fixes
the issue.

The patch check.c.patch fixes this issue and valgrind no longer shows
errors about uninitialised values.



-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (950, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages dosfstools depends on:
ii  libc6  2.19-12

dosfstools recommends no packages.

dosfstools suggests no packages.

--- src/check.orig.c	2014-11-09 15:22:25.983604172 +0100
+++ src/check.c	2014-11-09 15:22:32.279603988 +0100
@@ -959,6 +959,7 @@
 	fs_read(offset, sizeof(DIR_ENT), &de);
     else {
 	/* Construct a DIR_ENT for the root directory */
+	memset(&de, 0, sizeof(DIR_ENT));
 	memcpy(de.name, "           ", MSDOS_NAME);
 	de.attr = ATTR_DIR;
 	de.size = de.time = de.date = 0;


Reply to: