[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#749161: marked as done (Conflicting function definitions)

Your message dated Sat, 04 Oct 2014 09:54:41 +0000
with message-id <E1XaM2z-0002ak-7g@franck.debian.org>
and subject line Bug#749161: fixed in lgeneral 1.2.3+dfsg-2
has caused the Debian Bug report #749161,
regarding Conflicting function definitions
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
749161: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749161
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lgeneral
Version: 1.2.3+dfsg-1
Usertags: goto-cc
Tags: upstream

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
gcc -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -g -O2 -fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall  -fPIE -pie -Wl,-z,relro -Wl,-z,now -o testfile  testfile-file.o testfile-list.o testfile-misc.o ../util/libutil.a -lm 

error: conflicting function declarations "char_width"
old definition in module file file file.c line 230
void ()
new definition in module misc file sdl.h line 100
signed int (struct _Font *, char)
Makefile:346: recipe for target 'testfile' failed
make[4]: *** [testfile] Error 64

Reviewing the code here

http://sources.debian.net/src/lgeneral/1.2.3%2Bdfsg-1/src/file.c?hl=229,230#L228

it seems the linker is just shut up in a proper way as, really, at least the
types should match to avoid a chance of undefined behaviour.

Best,
Michael

Attachment: pgpGObUUdcDHb.pgp
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: lgeneral
Source-Version: 1.2.3+dfsg-2

We believe that the bug you reported is fixed in the latest version of
lgeneral, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 749161@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Markus Koschany <apo@gambaru.de> (supplier of updated lgeneral package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 30 Sep 2014 11:30:10 +0200
Source: lgeneral
Binary: lgeneral lgc-pg
Architecture: source amd64
Version: 1.2.3+dfsg-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Markus Koschany <apo@gambaru.de>
Description:
 lgc-pg     - LGeneral converter for Panzer General game data
 lgeneral   - strategy game in the tradition of Panzer General
Closes: 193061 749161
Changes:
 lgeneral (1.2.3+dfsg-2) unstable; urgency=medium
 .
   * Add conflicting-function-declarations.patch.
     - Fix possible undefined compiler behaviour. Thanks to Michael Tautschnig
       for the report and patch. (Closes: #749161)
   * Update copyright years.
   * debian/control:
     - Declare compliance with Debian policy 3.9.6.
     - Only suggest game-data-packager since LGeneral is going to be installed
       into the main archive.
     - Change Section to games.
       A free data package, lgeneral-data, is now available hence the game can
       be moved to main. (Closes: #193061)
     - Move lgc-pg to Recommends because it is not strictly required to run the
       game. It is still very useful for development purposes.
     - Depend on lgeneral-data.
     - Update package description of the lgeneral binary package.
   * lgeneral.menu: Update longtitle.
   * debian/rules:
     - Replace dh_auto_install override with dh_install override.
     - Do not export DH_OPTIONS. It seems to make no difference.
   * Drop source/include-binaries because it is not necessary for the xpm file.
   * Fix lintian warning wrong weekday.
   * Update README.Debian. Mention new free data package.
Checksums-Sha1:
 d18dbe97f7fb62204fa23e57cc8fb6f0d89efb0f 2024 lgeneral_1.2.3+dfsg-2.dsc
 ebeacfff07ddb7160df391c1dcaed872a3be345b 1594154 lgeneral_1.2.3+dfsg.orig.tar.gz
 da3989045027dbdca3debe2dc1ded7157112f52a 16676 lgeneral_1.2.3+dfsg-2.debian.tar.xz
 55d63b5bacbf80942983139de72cebe17bd5e0c6 503374 lgeneral_1.2.3+dfsg-2_amd64.deb
 322e300a6e924eed901af1ac410e76e250c7a307 362128 lgc-pg_1.2.3+dfsg-2_amd64.deb
Checksums-Sha256:
 09d183335951b229ad59e9ee673d9ccc71e931aa65efa5dd670d2195a8f1f342 2024 lgeneral_1.2.3+dfsg-2.dsc
 d64068b0bc9d70a5d7505742f9ee0a1d7ca59b2a01406d5471e8ae47310313c2 1594154 lgeneral_1.2.3+dfsg.orig.tar.gz
 a8cb32c54e21ea0dc57f5cc4028e9fc2e11772f81b28929502468a7fc8bfad81 16676 lgeneral_1.2.3+dfsg-2.debian.tar.xz
 d3df37eeb3dc1ef1a5f99f6d4a240c6a7d0fa617270d597feaa23342392b1218 503374 lgeneral_1.2.3+dfsg-2_amd64.deb
 c6351bd9c12d8b7e6dcce235d05763ed1af16e200afdd875a8b90b27240baf09 362128 lgc-pg_1.2.3+dfsg-2_amd64.deb
Files:
 b0a413a8057ba2a0e6164e821aef247a 503374 games optional lgeneral_1.2.3+dfsg-2_amd64.deb
 535a9bc2781306a47ff0cc624c1b5b08 362128 games optional lgc-pg_1.2.3+dfsg-2_amd64.deb
 eb6944e838b550ba7a4d7378899ad31b 2024 games optional lgeneral_1.2.3+dfsg-2.dsc
 d16a0d2e02941d0f640c1931ec5df06d 1594154 games optional lgeneral_1.2.3+dfsg.orig.tar.gz
 b68f1c3ffe031ab3ec2e2f23c9782c60 16676 games optional lgeneral_1.2.3+dfsg-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJUL7wUAAoJEHQmOzf1tfkTYScP/1vqPe/PBv1ozPeWV1OlRJT6
ONCwGs/B0EsABC29gnbB1xnwJ10PCB9fY/+y3VRuRxT9ztiHwvcXG+4tYJjKTWrO
u8bcWP8MqNzszZQh9rJ/Hkx3F0ssLmgovgA6Q3udcG2AojW+BC/ROMfD51jRtFK2
HKJnc02nvf0Hk+2HU8dQBkHgEg8lSv8njS3byIQ6uDxKvXmKCoglX+YYByAOEif1
arAomXtkD9mlJjsK7Cu+/KBuylJCJ0lOt/IEbE6wGpd0f4Nt2+ffCMQ8v6kZquZH
NEDNS30gChMNbqFTf5uF9ArlMXi2EJKPGPk+YKX8NPOuPbF2A5TVMPcopuhlsN2f
a9zQQMBLGg5eGriBuGbWMtnEHLYgpfwOy+H+Gr5SZEvZp9KPMIHhjWuFiy+Evbgs
h4XsnUi7sKdGoFs4LuG+UveMQv0Qscsk+GpLo6+SsffqFY6+ofJxn/hgixTFt2Mn
Afo6AyqefuBb16RxxOAgdCePz1kTMlITnKVpBTkVL1eXWkkM7zsY49EEBRRR+LoG
wOBO8GxJTgKaPvMPrhh1R66888FvI936rZfK5Rg38qFJxr8kMFmkt4HNYRUVUkNP
GBFix09t2EjBt8UkZhgt9DdUrzYH/1o2PfiMCko8OCLHyZ6mpYMuFeRAV9FHUaVI
htAn8ILMgdwsrcGnv9km
=nAPB
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: