--- Begin Message ---
Package: freeimage
Version: 3.15.4-3
Tags: sid patch
Severity: important
User: debian-mips-dev-discuss@lists.alioth.debian.org
Usertags: mips-patch
Control: block -1 by 763255
Package skimage FTBFS on testing for mips:
> ======================================================================
> FAIL: test_freeimage.test_imread
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
> self.test(*self.arg)
> File "/usr/lib/python2.7/dist-packages/numpy/testing/decorators.py", line 146, in skipper_func
> return f(*args, **kwargs)
> File "/«PKGBUILDDIR»/debian/tmp/usr/lib/python2.7/dist-packages/skimage/io/tests/test_freeimage.py", line 38, in test_imread
> assert all(img[274, 135] == [0, 130, 253])
> AssertionError
>
> ----------------------------------------------------------------------
> Ran 1033 tests in 1239.576s
>
> FAILED (SKIP=20, failures=1)
Test reads info from color.png with coordinates [274, 135].
Obtained result is [253 130 0], instead of expected [0, 130, 253].
It seems that color format is twisted (RGB -> BGR)
during loading of PNG.
The reason for that is a fact that big endian
was not detected right in FreeImage.h.
Patch that improves big endian detection in freeimage is attached.
Using freeimage, that conatins these changes
I was able to build skimage successfully on mips,
with all tests passing.
Could you please consider including this patch?
The same test is failing on sparc and s390s (BE archs),
I suppose that this fix could solve this issue on
those architectures as well.
Best Regards,
Dejan
diff -uNr freeimage-3.15.4.orig/Source/FreeImage.h freeimage-3.15.4/Source/FreeImage.h
--- freeimage-3.15.4.orig/Source/FreeImage.h 2014-09-30 15:13:07.000000000 +0000
+++ freeimage-3.15.4/Source/FreeImage.h 2014-09-30 15:23:06.000000000 +0000
@@ -73,6 +73,7 @@
// If your big endian system isn't being detected, add an OS specific check
#if (defined(BYTE_ORDER) && BYTE_ORDER==BIG_ENDIAN) || \
(defined(__BYTE_ORDER) && __BYTE_ORDER==__BIG_ENDIAN) || \
+ (defined(__BYTE_ORDER__) && __BYTE_ORDER__==__ORDER_BIG_ENDIAN__) || \
defined(__BIG_ENDIAN__)
#define FREEIMAGE_BIGENDIAN
#endif // BYTE_ORDER
--- End Message ---
--- Begin Message ---
Source: freeimage
Source-Version: 3.15.4-4
We believe that the bug you reported is fixed in the latest version of
freeimage, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 763730@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Anibal Monsalve Salazar <anibal@debian.org> (supplier of updated freeimage package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 02 Oct 2014 10:18:47 +0100
Source: freeimage
Binary: libfreeimage-dev libfreeimage3 libfreeimage3-dbg
Architecture: source mips
Version: 3.15.4-4
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Anibal Monsalve Salazar <anibal@debian.org>
Description:
libfreeimage-dev - Support library for graphics image formats (development files)
libfreeimage3 - Support library for graphics image formats (library)
libfreeimage3-dbg - Support library for graphics image formats (debugging symbols)
Closes: 763255 763730
Changes:
freeimage (3.15.4-4) unstable; urgency=medium
.
* QA upload.
* Build-depend on libjpeg8-dev.
Patch by Dejan Latinovic <Dejan.Latinovic@imgtec.com>.
Closes: #763255.
* Improve big endian detection.
Add fix-big-endian-detection.patch.
Patch by Dejan Latinovic <Dejan.Latinovic@imgtec.com>.
Closes: #763730.
* Refresh patches
Checksums-Sha1:
22ced0f8d8f7ac16fa3fcaf4216a609d42f206a0 2156 freeimage_3.15.4-4.dsc
a63298ca13d3c29fc01ed7a0fc90e5f77579f758 16432 freeimage_3.15.4-4.debian.tar.xz
b06513efb2daf8513f350b6343e1cc486a8c5ff0 1222080 libfreeimage-dev_3.15.4-4_mips.deb
b057ee705f0337f94fbb1e74ba644b739ad988af 301636 libfreeimage3_3.15.4-4_mips.deb
d79ad5fdf5212b2e6c6da437be901e1653dc98c7 1124868 libfreeimage3-dbg_3.15.4-4_mips.deb
Checksums-Sha256:
73631af79a446deef93c08450194acbc424d18216847443029b0037b554c1584 2156 freeimage_3.15.4-4.dsc
153283a68b548fb9de71acc049d82309052039ac33dddebdde3e1111513daa91 16432 freeimage_3.15.4-4.debian.tar.xz
5adb54b99d935374e67497e116d25ae32d4e495d9c9eb0f51a0fc5c3267e7f0b 1222080 libfreeimage-dev_3.15.4-4_mips.deb
7fd6867201c5f4912ffee0caeb1b0f44261825ba2903d7942caf998195d20613 301636 libfreeimage3_3.15.4-4_mips.deb
6a1283682fccc83474fe0c9e6328e867092deab180056b9b47c3adc03069654e 1124868 libfreeimage3-dbg_3.15.4-4_mips.deb
Files:
120fe2894a5d7f6cbc394010062470b3 1222080 libdevel optional libfreeimage-dev_3.15.4-4_mips.deb
a22dc8407f22b7ca905b5ba6aed513a3 301636 libs optional libfreeimage3_3.15.4-4_mips.deb
82f02a9ee966f306ae3d364ccfc1e43e 1124868 debug extra libfreeimage3-dbg_3.15.4-4_mips.deb
91c2710563626e94b9354450d7b35368 2156 libs optional freeimage_3.15.4-4.dsc
29651f6bb01298c977e0e0c90e4dd9bb 16432 libs optional freeimage_3.15.4-4.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCgAGBQJULR/YAAoJEHxWrP6UeJfYtDUQAIKroFeEEYwjdz+skQWcI1TF
nHn/OIBzyZVZ0vtMpcj3MCtiVnriWqCLQKRdjmEDDnplL79JWAXJSFWjzwT+MQ/V
xKR6MjP1NX7GKN7cFSHC/NQSWFa4vCYy+iTzA5mu3Pznlg7yjPo+AvWucURHu/Id
289sM8E5hhjztL1KUjeqQYDb/v3i/wgevFRpsGoSLJzOEuZ9D/wR7v6CHt7r65Ue
XLbESzvhd8CMccbVjf2dIHavSXZVck95LkoIqhJwkWCDrpU7gjj3rsJ6QSpkCivc
ruxdKLGRjzQBdw7o2jUt9Jff7WeTdOWrAF9xxgWmLCcbNuQSBqDcubSyIa9xDuyB
X9kB29iWjpRB18kzC4/AhB2vVBwBEIZ49l/MUCUKdG5pXGNuJEXvXuVVI7B8D+s1
7RvhSjafrSOHNemX9hyeBiyz6Ssf2z/CN4XjDEzKx7QSInvhc8rNZII68NECBcWV
QwwN5iY4GKj5Wy+8iM+JrUzmP/M8a9S0byn8Mbpvb+2yEC6WYo2hJYZloo/klDqD
trSvtoKjibjMBb2rlNdneL52/wmjPMeb/cGTTITcX8onH5zmLIV4ik4IZiSUbvZy
c3LGEM/ob9ZJ3gZY6LRJsk4v+sn4yi55HGmBei6gZZ9+IfHMwfK2d6gSpSKFqE6O
4/Ij33kyM3JGlCb7Mxqt
=UvYf
-----END PGP SIGNATURE-----
--- End Message ---