Bug#760165: graphviz: [kfreebsd] multithreaded dot hangs sometimes
tags 760165 + patch
thanks
On 01/09/14 17:51, Gilles Filippini wrote:
> On Mon, 01 Sep 2014 13:33:26 +0100 Steven Chamberlain
> <steven@pyro.eu.org> wrote:
>> This does look like a bug in graphviz running with multiple threads
>
> Doesn't it look like #701832 that you fixed a while ago?
Wow, that was 18 months ago, I had absolutely no memory of that!
> Looking at lib/gvc/gvconfig.c, the /proc/self/map related code isn't
> guarded by #ifdef linux anymore.
You're right, the patch got out of sync with upstream and was removed in
error. I've attached an updated version.
With it, I was able to build the shogun documentation successfully on
kfreebsd-i386 with 5 threads.
Thanks,
Regards,
--
Steven Chamberlain
steven@pyro.eu.org
--- a/lib/gvc/gvconfig.c
+++ b/lib/gvc/gvconfig.c
@@ -328,6 +328,7 @@ char * gvconfig_libdir(GVC_t * gvc)
}
}
#else
+#ifdef linux
FILE* f = fopen ("/proc/self/maps", "r");
char* path;
if (f) {
@@ -356,6 +357,7 @@ char * gvconfig_libdir(GVC_t * gvc)
}
#endif
#endif
+#endif
}
}
if (gvc->common.verbose && !dirShown) {
Reply to: