Bug#758328: avbin: Use pkg-config to determine FFmpeg linker flags
Source: avbin
Version: 7-4
Severity: wishlist
Tags: patch
Usertags: reintroducing-ffmpeg
Dear maintainer,
I am working on reintroducing FFmpeg to Debian [1-2].
In order to make FFmpeg co-installable with Libav, the libraries were
renamed to lib*-ffmpeg. Thus using linker flags like '-lavcodec' doesn't
work with the FFmpeg packages.
To get the correct linking flags for both FFmpeg and Libav, one can
(and should) use pkg-config.
Attached patch achieves that for this package. Please apply it to
facilitate building your package with FFmpeg in Debian.
If you want to facilitate this even further, you can also add
lib*-ffmpeg-dev alternatives to the Libav build-dependencies.
While the FFmpeg package is still waiting in the NEW queue [3], it can
already be built from the git repository [4].
Best regards,
Andreas
1: https://lists.debian.org/debian-devel/2014/07/msg01010.html
2: https://bugs.debian.org/729203
3: https://ftp-master.debian.org/new/ffmpeg_7:2.3.1-1.html
4: https://anonscm.debian.org/cgit/collab-maint/ffmpeg.git
diff --git a/debian/build/Makefile.am b/debian/build/Makefile.am
index 4ee9269..0c274c3 100644
--- a/debian/build/Makefile.am
+++ b/debian/build/Makefile.am
@@ -7,4 +7,4 @@ libavbin_la_CPPFLAGS= -DAVBIN_VERSION=7 -DFFMPEG_REVISION=15943 \
-I$(top_srcdir) -I../../include -I/usr/include/libavformat \
-I/usr/include/libavcodec -I/usr/include/libavutil -I/usr/include/libswscale
libavbin_la_LDFLAGS= -version-info 0:7:0
-libavbin_la_LIBADD= -lavutil -lavcodec -lavformat -lswscale
+libavbin_la_LIBADD= $(FFMPEG_LIBS)
diff --git a/debian/build/configure.ac b/debian/build/configure.ac
index ea8768f..0fcfb88 100644
--- a/debian/build/configure.ac
+++ b/debian/build/configure.ac
@@ -24,6 +24,9 @@ AC_TYPE_INT64_T
AC_TYPE_SIZE_T
AC_TYPE_UINT8_T
+# Check for FFmpeg
+PKG_CHECK_MODULES(FFMPEG,[ libavcodec libavformat libswscale libavutil ])
+
# Checks for library functions.
AC_FUNC_MALLOC
diff --git a/debian/control b/debian/control
index c93b3fd..6a02605 100644
--- a/debian/control
+++ b/debian/control
@@ -3,6 +3,7 @@ Maintainer: Debian QA Group <packages@qa.debian.org>
Section: utils
Priority: extra
Build-Depends: debhelper (>= 9),
+ pkg-config,
dh-autoreconf,
autoconf,
automake,
Reply to: