[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#749061: graphviz: Fix typo to ensure autoconf files are updated forbuild



Package: graphviz
Version: 2.26.3-17
Severity: serious
Tags: patch
Justification: fails to build from source
User: debian-arm@lists.debian.org
Usertag: arm64

Graphviz now uses dh_autoreconf and has stuff in the rules file to
update all three copies of config.{sub,guess} (hooray!), but a path
mistake meant that the copies in libltld/config were not being
replaced (instead a 4th set was added in the dir above).

This meant that the libltld suddir ./configure on any arch too new for
the shipped config.{sub,guess} failed. This failed on arm64 as they
are too old for that.

A more robust fix for this would probably be to simply use
dh_autotools-dev as well as dh_autoreconf to ensure that all copies
are updated, without having to maintain paths to a list of them in the
rules file. I don't know if the maintainer had a good reason for
trying to avoid the use of that helper?

Attached is the minimal fix that keeps the existing mechanism but I
don't actually think this is better. I'm happy to do a fix using
autotools-dev if the maintainer would prefer (and NMU it). 

Graphviz is blocking a lot of package builds on arm64 so I'd
appreciate either an upload or request to NMU reasonably quickly. Cheers.

-- System Information:
Debian Release: 7.5
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-kvm-i386-20110111 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru graphviz-2.26.3/debian/changelog graphviz-2.26.3/debian/changelog
--- graphviz-2.26.3/debian/changelog	2014-04-20 14:17:40.000000000 +0000
+++ graphviz-2.26.3/debian/changelog	2014-05-23 14:26:24.000000000 +0000
@@ -1,3 +1,9 @@
+graphviz (2.26.3-17+cfg) unreleased; urgency=low
+
+  * Correct typo in rules so config.{sub,guess} is actually updated.
+
+ -- Wookey <wookey@debian.org>  Fri, 23 May 2014 14:25:42 +0000
+
 graphviz (2.26.3-17) unstable; urgency=medium
 
   * QA upload.
diff -Nru graphviz-2.26.3/debian/rules graphviz-2.26.3/debian/rules
--- graphviz-2.26.3/debian/rules	2014-02-12 02:45:51.000000000 +0000
+++ graphviz-2.26.3/debian/rules	2014-05-23 14:24:42.000000000 +0000
@@ -35,8 +35,8 @@
 
 RUBY_PACKAGE      = $(CURDIR)/debian/libgv-ruby
 
-CONFIG_SCRIPTS=config/config.guess lib/gd/config/config.guess libltdl/config.guess \
-	       config/config.sub   lib/gd/config/config.sub   libltdl/config.sub
+CONFIG_SCRIPTS=config/config.guess lib/gd/config/config.guess libltdl/config/config.guess \
+	       config/config.sub   lib/gd/config/config.sub   libltdl/config/config.sub
 
 # make's $(shell) doesn't use local variables, thus we need to define a
 # custom command where DEB_LDFLAGS_MAINT_APPEND is passed.

Reply to: