[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#736211: marked as done (src:blackbox: FTBFS on x32)

Your message dated Thu, 23 Jan 2014 10:48:32 +0000
with message-id <E1W6Hpo-0002A6-9e@franck.debian.org>
and subject line Bug#736211: fixed in blackbox 0.70.1-20
has caused the Debian Bug report #736211,
regarding src:blackbox: FTBFS on x32
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
736211: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736211
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: src:blackbox
Version: 0.70.1-18
Severity: wishlist
Tags: patch


Hi!  Blackbox fails to build on x32, for two reasons:
* it uses implicit casts between time_t and long, in template disambiguation
  where exact types are needed
* its hand-written symbol arch table needs inclusion of x32

Patch attached.


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (600, 'unstable'), (500, 'experimental')
Architecture: x32 (x86_64)

Kernel: Linux 3.13.0-x32+ (SMP w/6 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -urd blackbox-0.70.1.0/debian/libbt0.symbols blackbox-0.70.1/debian/libbt0.symbols
--- blackbox-0.70.1.0/debian/libbt0.symbols	2013-11-20 14:25:58.000000000 +0100
+++ blackbox-0.70.1/debian/libbt0.symbols	2014-01-20 17:16:40.539105265 +0100
@@ -386,7 +386,7 @@
  (optional)_ZNSbIjSt11char_traitsIjESaIjEE12_M_leak_hardEv@Base 0.70.1
  (optional)_ZNSbIjSt11char_traitsIjESaIjEE12_S_constructIN9__gnu_cxx17__normal_iteratorIPKjS2_EEEEPjT_SA_RKS1_St20forward_iterator_tag@Base 0.70.1
  (optional)_ZNSbIjSt11char_traitsIjESaIjEE15_M_replace_safeEjjPKjj@Base 0.70.1
- (arch=!any-i386 !alpha !armel !armhf !ia64 !m68k !mips !mipsel !powerpc !powerpcspe !ppc64 !s390 !s390x !sh4 !sparc !sparc64)_ZNSbIjSt11char_traitsIjESaIjEE15_M_replace_safeEmmPKjm@Base 0.70.1
+ (arch=!any-i386 !alpha !armel !armhf !ia64 !m68k !mips !mipsel !powerpc !powerpcspe !ppc64 !s390 !s390x !sh4 !sparc !sparc64 !x32)_ZNSbIjSt11char_traitsIjESaIjEE15_M_replace_safeEmmPKjm@Base 0.70.1
  _ZNSbIjSt11char_traitsIjESaIjEE4_Rep20_S_empty_rep_storageE@Base 0.70.1
  (optional)_ZNSbIjSt11char_traitsIjESaIjEE4_Rep8_M_cloneERKS1_j@Base 0.70.1
  (optional)_ZNSbIjSt11char_traitsIjESaIjEE4_Rep8_M_cloneERKS1_m@Base 0.70.1
@@ -395,7 +395,7 @@
  (optional)_ZNSbIjSt11char_traitsIjESaIjEE6appendEmj@Base 0.70.1
  (optional)_ZNSbIjSt11char_traitsIjESaIjEE6assignERKS2_@Base 0.70.1
  (optional)_ZNSbIjSt11char_traitsIjESaIjEE6resizeEjj@Base 0.70.1
- (arch=!any-i386 !alpha !armel !armhf !ia64 !m68k !mips !mipsel !powerpc !powerpcspe !ppc64 !s390 !s390x !sh4 !sparc !sparc64)_ZNSbIjSt11char_traitsIjESaIjEE6resizeEmj@Base 0.70.1
+ (arch=!any-i386 !alpha !armel !armhf !ia64 !m68k !mips !mipsel !powerpc !powerpcspe !ppc64 !s390 !s390x !sh4 !sparc !sparc64 !x32)_ZNSbIjSt11char_traitsIjESaIjEE6resizeEmj@Base 0.70.1
  (arch=!amd64 !ia64 !kfreebsd-amd64 !mips64 !mips64el !s390 !s390x !alpha !ppc64 !sparc64)_ZNSbIjSt11char_traitsIjESaIjEE7replaceEjjPKjj@Base 0.70.1
  (arch=amd64 ia64 kfreebsd-amd64 mips64 mips64el s390 s390x alpha ppc64 sparc64)_ZNSbIjSt11char_traitsIjESaIjEE7replaceEmmPKjm@Base 0.70.1
  (arch=!amd64 !ia64 !kfreebsd-amd64 !mips64 !mips64el !s390 !s390x !alpha !ppc64 !sparc64)_ZNSbIjSt11char_traitsIjESaIjEE7reserveEj@Base 0.70.1
diff -urd blackbox-0.70.1.0/src/Toolbar.cc blackbox-0.70.1/src/Toolbar.cc
--- blackbox-0.70.1.0/src/Toolbar.cc	2005-04-12 09:38:00.000000000 +0200
+++ blackbox-0.70.1/src/Toolbar.cc	2014-01-20 17:12:33.059144580 +0100
@@ -44,8 +44,8 @@
 {
   timeval now;
   gettimeofday(&now, 0);
-  return (std::max(1000l, ((((resolution - (now.tv_sec % resolution)) * 1000l))
-                           - (now.tv_usec / 1000l))));
+  return (std::max((time_t)1000, ((((resolution - (now.tv_sec % resolution)) * 1000))
+                           - (now.tv_usec / 1000))));
 }

--- End Message ---
--- Begin Message --- 
Source: blackbox
Source-Version: 0.70.1-20

We believe that the bug you reported is fixed in the latest version of
blackbox, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 736211@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
HIGUCHI Daisuke (VDR dai) <dai@debian.org> (supplier of updated blackbox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 23 Jan 2014 19:38:41 +0900
Source: blackbox
Binary: blackbox libbt-dev libbt0
Architecture: source amd64
Version: 0.70.1-20
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: HIGUCHI Daisuke (VDR dai) <dai@debian.org>
Description: 
 blackbox   - Window manager for X
 libbt-dev  - Blackbox - development library
 libbt0     - Blackbox - shared library
Closes: 736211
Changes: 
 blackbox (0.70.1-20) unstable; urgency=medium
 .
   * QA upload.
   * Brown Paper Bag release.
   * really fix FTBFS on x32 (Closes: #736211).
     thanks to Adam Borowski <kilobyte@angband.pl>.
     - debian/libbt0.symbols: update.
Checksums-Sha1: 
 9e768735a6fa80f947075ff0ddbe88384214b53a 2023 blackbox_0.70.1-20.dsc
 ec9095340a7b9468685d9d6990688af4a215279e 20248 blackbox_0.70.1-20.debian.tar.xz
 3fb6332c60e010068388f32a5811a005c77aef1d 206510 blackbox_0.70.1-20_amd64.deb
 9e3b01323608f064b53ab2a16879ebd06394e0a2 102336 libbt-dev_0.70.1-20_amd64.deb
 12f902d287ea57aa69564049e06e94386a7dd502 90948 libbt0_0.70.1-20_amd64.deb
Checksums-Sha256: 
 4682741638b405f2140a0eb35bf81f13310d19e7d8e823f7d69c71f8a23ec14f 2023 blackbox_0.70.1-20.dsc
 1157130410df1e51f14df3b01cad0b479832518865a4e21b7fb790e77ffefe04 20248 blackbox_0.70.1-20.debian.tar.xz
 6297c22fc450e569c59db8256966deca428c5ee06a7b5ed9eefd30a80c0a3d22 206510 blackbox_0.70.1-20_amd64.deb
 5728a4ae262cbf881c26fa35c9a0b623e7a704c22e1e3d372bc79c56252d8ef2 102336 libbt-dev_0.70.1-20_amd64.deb
 728af0229a1a32f7ba59a0f9540ee6e2f93e8317d8bd73e1ffc2ef932e88fac2 90948 libbt0_0.70.1-20_amd64.deb
Files: 
 064a39623de2aff1145cc71a891861e0 2023 x11 optional blackbox_0.70.1-20.dsc
 54d97f57fcede6a6ad064b010bf7a922 20248 x11 optional blackbox_0.70.1-20.debian.tar.xz
 20b968a8f9eb39c1d7d433241c83d41c 206510 x11 optional blackbox_0.70.1-20_amd64.deb
 ebbb42eeac06b361a8df7282c6543efa 102336 libdevel optional libbt-dev_0.70.1-20_amd64.deb
 f5346a5a20df0dd7d92cfa876bbd519b 90948 libs optional libbt0_0.70.1-20_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJS4PJMAAoJEHg5YZ3UOWaO8bUQAK+CKHcwZ02r0gbHeGzSGkFx
V+6RwBEQpEjkE2sgnvwbKmHj9sxAV9Y0gFq67VxvgvHbpaE2V/FiDuAbGH1TV+7n
zg5wDeKM5gR4H/juNbRuEpJsTJ6hVYSyg248R8j4X3naS3H7n+jH017lTT75cJ3z
W+Vo/1IrUpDTklDO97eS5V4b0bYVXnIe+QtinmQP213T6VYwiLgvzYwk6iOOQHMf
ePLb3V5e23ghI2RO0mt+unCO5u2vVH7A3feQZJwQm6gpEdkL+1jwXB7uLuUMfzXf
edOJVJb0FqzQNgRhQ0pvSvWyzV/1IEBYhWzd49C7VvmpV0NSoaKj0XmvqaRnEONO
jZhJTpjeXc5Mw1ZjMZbIMwJEFBMv00+piRq9nnlSTIu1XTo5p1z3FfxlSs0Psib4
lknDkmf97Wyiv8dU62twRauUtsX/ms1uz9AZUtrYTwN1hXQzTB915+ztmaeeJHJ4
AaDCj8tI3zZsUnCKsdPVGAIVzH46bNx1Gsdu/qALBvBt5Hm6CBYDhncLqo3GvueS
ftPr+OphLIMONWPL+7trhwKrkqPM0sMiu5zNxiFpF63fABfJjZ/4fZM7iBDnayqs
2z1qsRDocJr5aOAIUWUpV8LLct4K3DreB7+9vWlR8j0wCJclpRj9hadr+Z01rYTK
n3FfCE7oUM8fkFdoNV+z
=YCKM
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: