[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#732996: sml-mode: incompatible w/xemacs21: uses 3-argument require



Package: sml-mode
Version: 5.0-1
Severity: important
Tags: patch

Byte compilation of sml-mode under xemacs21 fails because xemacs21
only supports the 1- and 2-argument forms of require:

  Compiling /usr/share/xemacs21/site-lisp/sml-mode/sml-mode.el...
  While compiling toplevel forms in file /usr/share/xemacs21/site-lisp/sml-mode/sml-mode.el:
    !! Wrong number of arguments ((require 3))
  >>Error occurred processing sml-mode.el: 
  Wrong number of arguments: require, 3

To accommodate this limitation, I'd suggest taking the same approach
for smie as for skeleton:

--- sml-mode.el~	2013-12-23 12:56:31.779955791 -0500
+++ sml-mode.el	2013-12-23 12:55:55.892380370 -0500
@@ -68,8 +68,8 @@
 ;;; Code:
 
 (eval-when-compile (require 'cl))
-(require 'smie nil 'noerror)
 
+(condition-case nil (require 'smie)     (error nil))
 (condition-case nil (require 'skeleton) (error nil))
 
 (defgroup sml ()

Alternatively, you could declare xemacs21 unsupported and not try to
byte compile for it, but that would be overkill for just this problem.

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable'), (300, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages sml-mode depends on:
ii  dpkg            1.16.12
ii  emacsen-common  2.0.5
ii  install-info    5.2.0.dfsg.1-2

sml-mode recommends no packages.

sml-mode suggests no packages.

-- no debconf information


Reply to: