Bug#726186: zvbi FTBFS on alpha due to bug in test suite

[Michael Cree <mcree@orcon.net.nz>]

Source: zvbi
Version: 0.2.35-1
Severity: important
User: debian-alpha@lists.debian.org
Usertags: alpha
Justification: Fails to build from source but built in the past

zvbi FTBFS on alpha (also ppc64 by the looks) due to a bug in the test
suite routine test-packet-830.  Build log for alpha at:

http://buildd.debian-ports.org/status/fetch.php?pkg=zvbi&arch=alpha&ver=0.2.35-1&stamp=1380861750

The problem is the function assert_decode_teletext_8301_cni() in
test/test-packet-830.cc which reads as:

static void                                                                       
assert_decode_teletext_8301_cni (unsigned int *         cni,
                                 const uint8_t          buffer[42])
{
        uint8_t buffer2[42];
        unsigned int cni2;

        memcpy (buffer2, buffer, sizeof (buffer2));
        memset_rand (cni, sizeof (cni));


That should be sizeof(*cni) in the last line.  The memset_rand() function
due to an incorrect size specification (8 bytes for a pointer on a 64 bit
arch like alpha) writes past the end of the 4 bytes of an unsigned int,
indeed into buffer2 which happened to be allocated after cni, causing a
later assert comparing buffer and buffer2 to fail.

Cheers
Michael.