[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#671384: marked as done (xplc: FTBFS on hurd-i386.)

Your message dated Mon, 13 May 2013 21:05:34 +0000
with message-id <E1Ubzw6-0007Qw-FV@franck.debian.org>
and subject line Bug#671384: fixed in xplc 0.3.13-4
has caused the Debian Bug report #671384,
regarding xplc: FTBFS on hurd-i386.
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
671384: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=671384
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xplc
Severity: important
Tags: upstream patch

Dear Maintainer,

xplc currently FTBFS on hurd-i386 because it uses the PATH_MAX macro, which is not defined on GNU/Hurd. The attached patch should fix this issue. Since PATH_MAX is not needed any more, it also removes the check for limits.h from configure.ac.

WBR,
Cyril Roelandt.

-- System Information:
Debian Release: wheezy/sid
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: hurd-i386 (i686-AT386)

Kernel: GNU-Mach 1.3.99/Hurd-0.3
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_MESSAGES to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

--- xplc-0.3.13.orig/xplc/modulemgr.cpp	2004-09-30 21:09:54.000000000 +0000
+++ xplc-0.3.13/xplc/modulemgr.cpp	2012-05-03 16:28:28.000000000 +0000
@@ -29,9 +29,6 @@
 #ifdef HAVE_STDINT_H
 # include <stdint.h>
 #endif
-#ifdef HAVE_LIMITS_H
-# include <limits.h>
-#endif
 
 #if !defined(WIN32)
 # if HAVE_DIRENT_H
@@ -83,7 +80,7 @@
 #if !defined(WIN32)
   DIR* dir;
   struct dirent* ent;
-  char fname[PATH_MAX];
+  char *fname;
   IServiceManager* servmgr = XPLC_getServiceManager();
   IModuleLoader* loader;
   ModuleNode* modules = 0;
@@ -106,7 +103,10 @@
   while((ent = readdir(dir))) {
     IModule* module;
 
-    snprintf(fname, PATH_MAX, "%s/%s", directory, ent->d_name);
+    size_t size;
+    size = snprintf(NULL, 0, "%s/%s", directory, ent->d_name) + 1;
+    fname = new char[size];
+    snprintf(fname, size, "%s/%s", directory, ent->d_name);
 
     module = loader->loadModule(fname);
     if(module) {
@@ -115,6 +115,8 @@
       if(node)
         modules = node;
     }
+
+    delete [] fname;
   }
 
   loader->release();
--- xplc-0.3.13.orig/configure.ac	2005-10-31 23:19:35.000000000 +0000
+++ xplc-0.3.13/configure.ac	2012-05-03 16:27:06.000000000 +0000
@@ -83,7 +83,6 @@
 AC_PROG_LN_S
 
 AC_HEADER_DIRENT
-AC_CHECK_HEADERS([limits.h])
 
 AC_CHECK_PROGS([CVS2CL], [cvs2cl.pl cvs2cl], [no])
 
--- xplc-0.3.13.orig/include/autoconf.h.in	2005-10-31 22:50:02.000000000 +0000
+++ xplc-0.3.13/include/autoconf.h.in	2012-05-03 16:28:50.000000000 +0000
@@ -13,9 +13,6 @@
 /* Define to 1 if you have the <inttypes.h> header file. */
 #undef HAVE_INTTYPES_H
 
-/* Define to 1 if you have the <limits.h> header file. */
-#undef HAVE_LIMITS_H
-
 /* Define to 1 if you have the <mach-o/dyld.h> header file. */
 #undef HAVE_MACH_O_DYLD_H

--- End Message ---
--- Begin Message --- 
Source: xplc
Source-Version: 0.3.13-4

We believe that the bug you reported is fixed in the latest version of
xplc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 671384@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Barry deFreese <bdefreese@debian.org> (supplier of updated xplc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 13 May 2013 12:00:03 -0400
Source: xplc
Binary: libxplc0.3.13 libxplc0.3.13-dev uuidcdef
Architecture: source i386
Version: 0.3.13-4
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Barry deFreese <bdefreese@debian.org>
Description: 
 libxplc0.3.13 - Light weight component system
 libxplc0.3.13-dev - Light weight component system (Development libraries and headers)
 uuidcdef   - Universally Unique Identifier (UUID) generator
Closes: 606835 671384 686267
Changes: 
 xplc (0.3.13-4) unstable; urgency=low
 .
   * QA upload.
   * Change to source 3.0 (quilt) format.
   * Fix FTBFS on GNU/Hurd. (Closes: #671384, #686267).
     - Thanks to Svante Signell and Cyril Roelandt for the patches.
   * Support --as-needed. (Closes: #606835).
     - Thanks to Stefan Potyra for the patch.
Checksums-Sha1: 
 1eea9503f04d13b315e47c0914666c38b35a466f 1173 xplc_0.3.13-4.dsc
 12b9ad4a7834fe1f1169273ff1208677d896cdf4 5426 xplc_0.3.13-4.debian.tar.gz
 fabf65f2ae6de660babc6f41999beefc81146d8c 41786 libxplc0.3.13_0.3.13-4_i386.deb
 a8255202a378f74f89495250e39d86bd07c57449 70966 libxplc0.3.13-dev_0.3.13-4_i386.deb
 e836b6c8eddafaa18dcf8dbf0f517da7f665c246 37072 uuidcdef_0.3.13-4_i386.deb
Checksums-Sha256: 
 8b174c71e8b1be7ada1d7d0540d571678a31444fb0e9e740220f5ceebbce79c8 1173 xplc_0.3.13-4.dsc
 6f0f56ef8ab6ac17d2006a27b15f105206b47ae88b792f53422ed871a4f11859 5426 xplc_0.3.13-4.debian.tar.gz
 01e347f3a0305c310f227b9694e2f0a61f6743fd5ce5249b3e731021aa9e99eb 41786 libxplc0.3.13_0.3.13-4_i386.deb
 1e8dffb4825e793a446a32bbf08809b8db67d811c419ea8b5c898398141c5684 70966 libxplc0.3.13-dev_0.3.13-4_i386.deb
 2e22fa5dc49af56544b9a99885e73b06247fbebab38639c9c262e6cfc0e78916 37072 uuidcdef_0.3.13-4_i386.deb
Files: 
 c6152ed6a3d0be395611cb76fc596218 1173 libs optional xplc_0.3.13-4.dsc
 4b8a5b6be6e6def266a429253ea1b1f0 5426 libs optional xplc_0.3.13-4.debian.tar.gz
 d1881eebac928beb05f9f92c823b70ac 41786 libs optional libxplc0.3.13_0.3.13-4_i386.deb
 3b4b14654502a2a21dc5b67369f73363 70966 libdevel optional libxplc0.3.13-dev_0.3.13-4_i386.deb
 4ac02bee93ee9d2485a8e8323baf63f7 37072 devel optional uuidcdef_0.3.13-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlGRGLsACgkQ5ItltUs5T372RwCgts2C3z2Km6lrO4SaibU1niNH
faIAoNn9OhD59+f7nff9WH0VVUMzHRz8
=ifoY
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: