[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#642501: marked as done (libaudit-dev: error codes for audit_open() failure not documented)

Your message dated Thu, 21 Mar 2013 21:03:25 +0000
with message-id <E1UImdx-0005fe-NI@franck.debian.org>
and subject line Bug#642501: fixed in audit 1:2.2.3-1
has caused the Debian Bug report #642501,
regarding libaudit-dev: error codes for audit_open() failure not documented
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

642501: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=642501
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: libaudit-dev
Version: 1.7.18-1
Severity: minor
Justification: documentation
Tags: upstream patch


Today in the boot log, I found

	systemd[1]: Failed to connect to audit log: Protocol not supported

Looking at the systemd source, I see that this means audit_open()
returned -1 with errno == EPROTONOSUPPORT.  The underlying cause is
that the kernel in use was built without audit support.

So far so sane.  I would like to consider patching systemd to accept
this error silently, just as though it had been built without libaudit
support.  Something like:

	if ((fd = audit_open(...)) < 0 && errno != EPROTONOSUPPORT)

One problem: is that the right errno check?  I.e., could audit_open
yield that error code for some other reason?  Alas, the audit_open(3)
manpage does not have an ERRORS section like open(2) does, so I don't

How about this patch?  It would have told me that another possibility
to check for is EAFNOSUPPORT and that these errno values indeed just
represent lack of kernel support.
 docs/audit_open.3 |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/docs/audit_open.3 b/docs/audit_open.3
index 0feb7828..6ec8eb0a 100644
--- a/docs/audit_open.3
+++ b/docs/audit_open.3
@@ -14,6 +14,18 @@ audit_open creates a NETLINK_AUDIT socket for communication with the kernel part
 Returns \-1 if an error occurs; otherwise, the return value is a descriptor referencing the socket.
+.BR audit_open ()
+function may fail and set
+.I errno
+for any of the errors specified for the
+.BR socket (2)
+.BR fcntl (2)
 .BR netlink (7).

--- End Message ---
--- Begin Message ---
Source: audit
Source-Version: 1:2.2.3-1

We believe that the bug you reported is fixed in the latest version of
audit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 642501@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Laurent Bigonville <bigon@debian.org> (supplier of updated audit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA256

Format: 1.8
Date: Thu, 21 Mar 2013 21:39:45 +0100
Source: audit
Binary: auditd libauparse0 libauparse-dev libaudit1 libaudit-common libaudit-dev python-audit audispd-plugins
Architecture: source amd64 all
Version: 1:2.2.3-1
Distribution: experimental
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Laurent Bigonville <bigon@debian.org>
 audispd-plugins - Plugins for the audit event dispatcher
 auditd     - User space tools for security auditing
 libaudit-common - Dynamic library for security auditing - common files
 libaudit-dev - Header files and static library for security auditing
 libaudit1  - Dynamic library for security auditing
 libauparse-dev - Header files and static library for the libauparse0 library
 libauparse0 - Dynamic library for parsing security auditing
 python-audit - Python bindings for security auditing
Closes: 642501 699933
 audit (1:2.2.3-1) experimental; urgency=low
   * QA upload.
   * New upstream release
     - Properly document audit_open() can fails and sets errno (Closes: #642501)
     - Drop all the patches, they have been applied upstream
   * Remove libev-dev Build-Dependency
     - debian/control: The upstream audit sources embed and build against their
       own version of libev. This is not desirable, but there's no reason to
       list libev-dev as a build dependency at this time. (Closes: #699933)
 af5fbfc21640ae3d28d5cf37fc2e55f6046793e1 1975 audit_2.2.3-1.dsc
 cdb2721d4e9361648359032a4d40d2c057abfe58 910762 audit_2.2.3.orig.tar.gz
 d6dbdf12ccad6db5492617002791a7cb91965584 10241 audit_2.2.3-1.debian.tar.gz
 0f886d36e2a6cc9ce695bcd6c309b05da0c60afb 274970 auditd_2.2.3-1_amd64.deb
 b7caefb400c93634de422bfcf878d6d84c56463b 50140 libauparse0_2.2.3-1_amd64.deb
 f85313a542e79ec777cb32e1a1cf863a25e900ec 81474 libauparse-dev_2.2.3-1_amd64.deb
 826d374ab5e566fc98f045f7c9e2e2d5e8159c19 57376 libaudit1_2.2.3-1_amd64.deb
 f5fb733735f01e01c839452b23800784fecf9237 18022 libaudit-common_2.2.3-1_all.deb
 69a9f3bdbfb7d88ba2f8f646e1942b16e14563c4 89750 libaudit-dev_2.2.3-1_amd64.deb
 f3a7380b67cfecbb54235b393bfc3af632d43df5 134956 python-audit_2.2.3-1_amd64.deb
 e2b38eba76ca720e47315e5e712ba8d0963fca88 80704 audispd-plugins_2.2.3-1_amd64.deb
 ab85c893f4e2fbbdc323f043b7242d882f443f573231cb17d6becb54ff69f272 1975 audit_2.2.3-1.dsc
 2fc8f97020121593f516dc011ef61f39043c4cea9b2cb9ab3849bf9e41dedf02 910762 audit_2.2.3.orig.tar.gz
 92bca9d93ac6be94dfb26e306c2771e67147bfa23c3fd817fcc4fb6deb4ec036 10241 audit_2.2.3-1.debian.tar.gz
 69d835572989024c5760ccf1dabad7b4e88740e3dd839eb0b6462f9532bd6c30 274970 auditd_2.2.3-1_amd64.deb
 83d90e86460d5dcf17e664fbe3ffb503431a0994c77ae4db063861d7f65c5ee9 50140 libauparse0_2.2.3-1_amd64.deb
 e5d4b4ecff6f090bf2073b8f5b20db64cb123d0c91d90743f7742f8761cbe635 81474 libauparse-dev_2.2.3-1_amd64.deb
 79b04f4c52cdebfec4d1d3d0ad537a2b54a6a8d75582299cdd27a55b945734fe 57376 libaudit1_2.2.3-1_amd64.deb
 73dd35ab7ee7832d7ec4db3a509cbcc72751b088e20d8dc29156c0a17355ff61 18022 libaudit-common_2.2.3-1_all.deb
 fb929ffc3712a91443436892f6bdce040a870e666b2ef9bf7ed515688d2c9b60 89750 libaudit-dev_2.2.3-1_amd64.deb
 c3cbb3a52eb46d509b437cefad808fcd6248e9708756d283eb6b795bee11dea1 134956 python-audit_2.2.3-1_amd64.deb
 6112262cdbf5133e1d6daef6dc1234649f5f2e387a41f1da2ea85012bcb46d9f 80704 audispd-plugins_2.2.3-1_amd64.deb
 0c3aee4931b9a92a0ecbd7327ee8728f 1975 libs extra audit_2.2.3-1.dsc
 4cdd3756f7b7122fc1a3e4627f01b446 910762 libs extra audit_2.2.3.orig.tar.gz
 d95f36effd921b747bfd079ff4114b14 10241 libs extra audit_2.2.3-1.debian.tar.gz
 5a8867102af95e2a3ce7015844968596 274970 admin extra auditd_2.2.3-1_amd64.deb
 d9ad340db44d510db1d5f3b09ec1e222 50140 libs optional libauparse0_2.2.3-1_amd64.deb
 d1ab009ea2ca839fad761ec6d823e723 81474 libdevel extra libauparse-dev_2.2.3-1_amd64.deb
 c4fc7fb46453a519445176121da79e53 57376 libs optional libaudit1_2.2.3-1_amd64.deb
 b2c4edd65bdf9063bafdbef285dd20e6 18022 libs optional libaudit-common_2.2.3-1_all.deb
 83c5125831e97db0b2b24a2bd6222895 89750 libdevel extra libaudit-dev_2.2.3-1_amd64.deb
 c36b28511bca8a6b9d496efc229b80a6 134956 python extra python-audit_2.2.3-1_amd64.deb
 06d610790684afb613c0387e8f5e7c54 80704 admin extra audispd-plugins_2.2.3-1_amd64.deb

Version: GnuPG v1.4.12 (GNU/Linux)


--- End Message ---

Reply to: