Your message dated Wed, 4 Jan 2012 02:27:14 +0100 with message-id <20120104012714.GB20942@sym.noone.org> and subject line xmcd has been removed from unstable, closing all according bugs has caused the Debian Bug report #223998, regarding cddbcmd leaves CR-LF on short lines to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 223998: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=223998 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: cddbcmd leaves CR-LF on short lines
- From: Kevin Dalley <kevind@rahul.net>
- Date: Sun, 14 Dec 2003 13:45:28 -0800
- Message-id: <20031214214528.145B21CDA16@nereocystis.kelphead.org>
Package: cddb Version: 2.6-17 Severity: normal When cddbcmd receives a short lines in response from cddbd, it leaves the CR-LF on the line, even though the characters are removed for short lines. This is particularly noticeable for "cddb read" commands. cddbcmd cddb read rock 89081e0b where the first few lines look like this: # xmcd CD database file # # Track frame offsets: I have a fix below which solves this problem, but there may be a reason for the slightly odd code where the check for CR-LF doesn't start until buf[4]. In the case where I have had problems, the second line looks like "#\r\n". It is only 3 characters long. Since the check starts after the end of the string, '\0' may not be found until after the end of the buffer. Unfortunately, there may be reason for starting the check at character 4, but it isn't explained in the source code. My suggested change starts the check at character 0, so every line has CR-LF deleted. Here's a patch which fixes the problem. --- cddbcmd.c~ 2003-12-14 12:36:02.000000000 -0800 +++ cddbcmd.c 2003-12-14 13:15:44.000000000 -0800 @@ -930,7 +930,7 @@ break; /* Eat CR-LF */ - for (p = buf + 4; *p != '\0'; p++) { + for (p = buf; *p != '\0'; p++) { if (*p == '\r') { *p = '\0'; break; -- System Information: Debian Release: testing/unstable Architecture: i386 Kernel: Linux nereocystis 2.4.21 #1 Wed Sep 17 12:11:03 PDT 2003 i686 Locale: LANG=C, LC_CTYPE=C Versions of packages cddb depends on: ii libc6 2.3.2.ds1-10 GNU C Library: Shared libraries an -- no debconf information
--- End Message ---
--- Begin Message ---
- To: 486771-done@bugs.debian.org
- Cc: 574799-done@bugs.debian.org, 223998-done@bugs.debian.org, 30344-done@bugs.debian.org, 35048-done@bugs.debian.org, 61458-done@bugs.debian.org, 93548-done@bugs.debian.org, 140050-done@bugs.debian.org, 191576-done@bugs.debian.org, 193801-done@bugs.debian.org, 268471-done@bugs.debian.org, 405229-done@bugs.debian.org, 457144-done@bugs.debian.org
- Subject: xmcd has been removed from unstable, closing all according bugs
- From: Axel Beckert <abe@debian.org>
- Date: Wed, 4 Jan 2012 02:27:14 +0100
- Message-id: <20120104012714.GB20942@sym.noone.org>
Version: 2.6-24+rm Hi, xmcd has been removed from unstable. See http://bugs.debian.org/653489 for the details. Closing the according bug reports. Regards, Axel -- ,''`. | Axel Beckert <abe@debian.org>, http://people.debian.org/~abe/ : :' : | Debian Developer, ftp.ch.debian.org Admin `. `' | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE `- | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
--- End Message ---