[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#692795: cvssuck: broken with Ruby 1.9 and non-UTF-8 commit log

Package: cvssuck
Version: 0.3.cvs20060124-2
Severity: important
Tags: l10n

If the ruby1.9.1 package is installed, cvssuck breaks if the commit log
is not a valid UTF-8 text:

$ cd $(mktemp -d)
$ mkdir tree suck
$ cd tree
$ cvs -d $PWD/../cvsroot init
$ cvs -d $PWD/../cvsroot import -m test test test start

No conflicts created by this import

$ cvs -d $PWD/../cvsroot checkout -d . test
cvs checkout: Updating .
$ touch a b c
$ cvs -d $PWD/../cvsroot add a b c
cvs add: scheduling file `a' for addition
cvs add: scheduling file `b' for addition
cvs add: scheduling file `c' for addition
cvs add: use `cvs commit' to add these files permanently
$ cvs -d $PWD/../cvsroot commit -m test a c
/tmp/tmp.VR40H0bICS/tree/../cvsroot/test/a,v  <--  a
initial revision: 1.1
/tmp/tmp.VR40H0bICS/tree/../cvsroot/test/c,v  <--  c
initial revision: 1.1
$ cvs -d $PWD/../cvsroot commit -m $(echo -e '\xff') b
/tmp/tmp.VR40H0bICS/tree/../cvsroot/test/b,v  <--  b
initial revision: 1.1
$ cd ../suck/
$ cvssuck -v $PWD/../cvsroot -o . test
["cvs", "-f", "update", "-r00", "-d", "-p", "a"]
["cvs", "-f", "log", "a"]
["cvs", "-f", "update", "-ko", "-r1.1", "a/a"]
["ci", "-q1.1", "-f", "-d2012-11-09 01:34:08 +0100", "-mtest", "-t-",
"-sExp", "-whippy", "./a,v", "/tmp/cvssuck-25180/t25185-5/a"]
["rlog", "./a,v"]
/usr/bin/cvssuck:335:in `split': invalid byte sequence in UTF-8 (ArgumentError)
	from /usr/bin/cvssuck:335:in `block in parse_log'
	from /usr/bin/cvssuck:329:in `open'
	from /usr/bin/cvssuck:329:in `parse_log'
	from /usr/bin/cvssuck:479:in `block in parselogs'
	from /usr/bin/cvssuck:435:in `run_cvs_internal'
	from /usr/bin/cvssuck:473:in `parselogs'
	from /usr/bin/cvssuck:1022:in `update_directory'
	from /usr/bin/cvssuck:1012:in `block in update_module'
	from /usr/bin/cvssuck:1010:in `fork'
	from /usr/bin/cvssuck:1010:in `update_module'
	from /usr/bin/cvssuck:1260:in `block in main'
	from /usr/bin/cvssuck:1257:in `each'
	from /usr/bin/cvssuck:1257:in `main'
	from /usr/bin/cvssuck:1270:in `<main>'
$ ls

Please change cvssuck to use /usr/bin/ruby1.8 and depend on the ruby1.8
package, or port it to Ruby 1.9.

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing'), (400, 'unstable'), (300, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 3.6.5 (SMP w/2 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cvssuck depends on:
ii  cvs             2:1.12.13+real-9
ii  rcs             5.8.1-1
ii  ruby1.8 [ruby]

Versions of packages cvssuck recommends:
ii  cvsconnect  0.1.cvs20001202-2

cvssuck suggests no packages.

-- no debconf information

Reply to: