[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#689896: marked as done (Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2))

Your message dated Wed, 17 Oct 2012 12:47:26 +0000
with message-id <E1TOT1y-0003qd-1q@franck.debian.org>
and subject line Bug#689896: fixed in lastfmsubmitd 1.0.6-4
has caused the Debian Bug report #689896,
regarding Ships a folder in /var/run or /var/lock (Policy Manual section 9.3.2)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

689896: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689896
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lastfmsubmitd
Version: 1.0.6-3
Severity: serious
Tags: patch

Dear Maintainer,

Andreas Beckmann <debian@abeckmann.de> reported in -devel that your package
(as well as 27 others) ships a folder either in /var/run or /var/lock. This
is forbidden by policy.

Lintian detects the problem and warns as follow:

/var/run may be a temporary filesystem, so any directories or files needed
/there must be created dynamically at boot time.

Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for

Severity: serious, Certainty: possible
Check: files, Type: binary, udeb

which is why I am reporting this bug with severity serious (and there fore,
release critical).

Please fix your package. I have attached what I believe is a good fix the
problem, however, I haven't tried it, and I haven't tested if something more
for creating the necessary folder at runtime should be added. Please make
sure to test before applying the patch blindly.


Thomas Goirand (zigo)
diff -u lastfmsubmitd-1.0.6/debian/lastfmsubmitd.dirs lastfmsubmitd-1.0.6/debian/lastfmsubmitd.dirs
--- lastfmsubmitd-1.0.6/debian/lastfmsubmitd.dirs
+++ lastfmsubmitd-1.0.6/debian/lastfmsubmitd.dirs
@@ -2,3 +2,2 @@
diff -u lastfmsubmitd-1.0.6/debian/lastmp.init.d lastfmsubmitd-1.0.6/debian/lastmp.init.d
--- lastfmsubmitd-1.0.6/debian/lastmp.init.d
+++ lastfmsubmitd-1.0.6/debian/lastmp.init.d
@@ -23,6 +23,14 @@
     exit 0
+if [ ! -d ${RUNDIR} ] ; then
+	mkdir -p ${RUNDIR} || true
+	if [ -d ${RUNDIR} ] ; then
+		chown ${USER}:${GROUP} ${RUNDIR}
+		chmod 2775 ${RUNDIR}
+	fi
 case "$1" in
         echo -n "Starting $DESC: "
diff -u lastfmsubmitd-1.0.6/debian/lastfmsubmitd.init.d lastfmsubmitd-1.0.6/debian/lastfmsubmitd.init.d
--- lastfmsubmitd-1.0.6/debian/lastfmsubmitd.init.d
+++ lastfmsubmitd-1.0.6/debian/lastfmsubmitd.init.d
@@ -21,6 +21,14 @@
     exit 0
+if [ ! -d ${RUNDIR} ] ; then
+	mkdir -p ${RUNDIR} || true
+	if [ -d ${RUNDIR} ] ; then
+		chown ${USER}:${GROUP} ${RUNDIR}
+		chmod 2775 ${RUNDIR}
+	fi
 case "$1" in
         echo -n "Starting $DESC: "
diff -u lastfmsubmitd-1.0.6/debian/changelog lastfmsubmitd-1.0.6/debian/changelog
--- lastfmsubmitd-1.0.6/debian/changelog
+++ lastfmsubmitd-1.0.6/debian/changelog
@@ -1,3 +1,10 @@
+lastfmsubmitd (1.0.6-3.1) unstable; urgency=low
+  * Non-maintainer upload.
+  * Fixes bad handling of /var/run/lastfm life cycle (Closes: #XXXXXX).
+ -- Thomas Goirand <zigo@debian.org>  Sat, 06 Oct 2012 18:41:00 +0800
 lastfmsubmitd (1.0.6-3) unstable; urgency=low
   * QA upload.
diff -u lastfmsubmitd-1.0.6/debian/lastfmsubmitd.postinst lastfmsubmitd-1.0.6/debian/lastfmsubmitd.postinst
--- lastfmsubmitd-1.0.6/debian/lastfmsubmitd.postinst
+++ lastfmsubmitd-1.0.6/debian/lastfmsubmitd.postinst
@@ -45,7 +45,7 @@
 db_get lastfmsubmitd/spool_group
 if [ "$RET" ]; then
-    for dir in /var/log/lastfm /var/run/lastfm /var/spool/lastfm; do
+    for dir in /var/log/lastfm /var/spool/lastfm; do
         chown "lastfm:$RET" $dir
         chmod 2775 $dir

--- End Message ---
--- Begin Message ---
Source: lastfmsubmitd
Source-Version: 1.0.6-4

We believe that the bug you reported is fixed in the latest version of
lastfmsubmitd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 689896@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Paul Gevers <elbrus@debian.org> (supplier of updated lastfmsubmitd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Wed, 17 Oct 2012 11:19:02 +0200
Source: lastfmsubmitd
Binary: lastfmsubmitd lastmp
Architecture: source all
Version: 1.0.6-4
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Paul Gevers <elbrus@debian.org>
 lastfmsubmitd - submission daemon for the Last.fm social music network
 lastmp     - MPD client for lastfmsubmitd
Closes: 689896
 lastfmsubmitd (1.0.6-4) unstable; urgency=low
   [ Thomas Goirand ]
   * Fixes bad handling of /var/run/lastfm life cycle (Closes: #689896).
   [ Paul Gevers ]
   * Prepare upload
 43764425296f5d640c9535c5d71139ef77434bea 1150 lastfmsubmitd_1.0.6-4.dsc
 d3eb98697ac9ee2886cb0011680721e89cb78075 17035 lastfmsubmitd_1.0.6-4.diff.gz
 013b59e852349dbeaba71d1f6ed36ae89b306d08 31938 lastfmsubmitd_1.0.6-4_all.deb
 002d0c639fc3036f15353187869431cbef78c75e 18118 lastmp_1.0.6-4_all.deb
 0fe39059979032a7b5438e867dd75668588299302e3d50674a42f317e106709e 1150 lastfmsubmitd_1.0.6-4.dsc
 4cec3f38acd479fcacb303bdc379a4fd9840507847862bb14e8395466bedbc00 17035 lastfmsubmitd_1.0.6-4.diff.gz
 81001e8432d492ab4e081f3a07033497a21b8653f2ea7ba6cc3227eb3e7f9ea2 31938 lastfmsubmitd_1.0.6-4_all.deb
 db528e3cb8c25aca0337b34b4ba8faa44b82cde5b46a2cf60e941aa83a5d67fc 18118 lastmp_1.0.6-4_all.deb
 193437ce6e716642ec7ec9ffa7783558 1150 sound optional lastfmsubmitd_1.0.6-4.dsc
 359624809b43f97a9089891059047c45 17035 sound optional lastfmsubmitd_1.0.6-4.diff.gz
 a67b8a33ba3000ab91a66c547b4bb1a9 31938 sound optional lastfmsubmitd_1.0.6-4_all.deb
 c60da3da9be06a180a08c370edae93ce 18118 sound optional lastmp_1.0.6-4_all.deb

Version: GnuPG v1.4.12 (GNU/Linux)


--- End Message ---

Reply to: