--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: rapidsvn SEGV with Subversion 1.7
- From: Philip Martin <philip@codematters.co.uk>
- Date: Wed, 05 Oct 2011 16:18:12 +0100
- Message-id: <20111005151812.19327.12350.reportbug@stat.home.lan>
Package: rapidsvn
Version: 0.12.0dfsg-2
Severity: normal
Tags: patch
The current released version of rapidsvn is incompatible with the
upcoming Subversion 1.7 due to the way rapidsvn constructs the
Subversion client context object. This causes rapidsvn to SEGV
on the first working copy operation.
A fix for this problem has been committed to rapidsvn trunk, but
is not yet in any release. The patch is r8195 in the upstream
repository.
Index: ../../rapidsvn-trunk/AUTHORS
===================================================================
--- ../../rapidsvn-trunk/AUTHORS (revision 8194)
+++ ../../rapidsvn-trunk/AUTHORS (revision 8195)
@@ -76,4 +76,4 @@
csola48 - translation
Alexey Reztsov - translation
Viet NQ - source code
-
+ Philip Martin - source code
Index: ../../rapidsvn-trunk/src/svncpp/context.cpp
===================================================================
--- ../../rapidsvn-trunk/src/svncpp/context.cpp (revision 8194)
+++ ../../rapidsvn-trunk/src/svncpp/context.cpp (revision 8195)
@@ -65,7 +65,7 @@
bool logIsSet;
int promptCounter;
Pool pool;
- svn_client_ctx_t ctx;
+ svn_client_ctx_t * ctx;
std::string username;
std::string password;
std::string logMessage;
@@ -180,22 +180,22 @@
svn_auth_open(&ab, providers, pool);
// initialize ctx structure
- memset(&ctx, 0, sizeof(ctx));
+ svn_client_create_context(&ctx, pool);
// get the config based on the configDir passed in
- svn_config_get_config(&ctx.config, c_configDir, pool);
+ svn_config_get_config(&ctx->config, c_configDir, pool);
// tell the auth functions where the config is
svn_auth_set_parameter(ab, SVN_AUTH_PARAM_CONFIG_DIR,
c_configDir);
- ctx.auth_baton = ab;
- ctx.log_msg_func = onLogMsg;
- ctx.log_msg_baton = this;
- ctx.notify_func2 = onNotify2;
- ctx.notify_baton2 = this;
- ctx.cancel_func = onCancel;
- ctx.cancel_baton = this;
+ ctx->auth_baton = ab;
+ ctx->log_msg_func = onLogMsg;
+ ctx->log_msg_baton = this;
+ ctx->notify_func2 = onNotify2;
+ ctx->notify_baton2 = this;
+ ctx->cancel_func = onCancel;
+ ctx->cancel_baton = this;
}
void setAuthCache(bool value)
@@ -204,7 +204,7 @@
if (!value)
param = (void *)"1";
- svn_auth_set_parameter(ctx.auth_baton,
+ svn_auth_set_parameter(ctx->auth_baton,
SVN_AUTH_PARAM_NO_AUTH_CACHE,
param);
}
@@ -215,7 +215,7 @@
username = usr;
password = pwd;
- svn_auth_baton_t * ab = ctx.auth_baton;
+ svn_auth_baton_t * ab = ctx->auth_baton;
svn_auth_set_parameter(ab, SVN_AUTH_PARAM_DEFAULT_USERNAME,
username.c_str());
svn_auth_set_parameter(ab, SVN_AUTH_PARAM_DEFAULT_PASSWORD,
@@ -604,13 +604,13 @@
Context::operator svn_client_ctx_t * ()
{
- return &(m->ctx);
+ return m->ctx;
}
svn_client_ctx_t *
Context::ctx()
{
- return &(m->ctx);
+ return m->ctx;
}
void
-- System Information:
Debian Release: 6.0.2
APT prefers stable
APT policy: (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages rapidsvn depends on:
ii libapr1 1.4.2-6+squeeze3 The Apache Portable Runtime Librar
ii libaprutil1 1.3.9+dfsg-5 The Apache Portable Runtime Utilit
ii libc6 2.11.2-10 Embedded GNU C Library: Shared lib
ii libdb4.8 4.8.30-2 Berkeley v4.8 Database Libraries [
ii libexpat1 2.0.1-7 XML parsing C library - runtime li
ii libgcc1 1:4.4.5-8 GCC support library
ii libstdc++6 4.4.5-8 The GNU Standard C++ Library v3
ii libsvn1 1.6.12dfsg-6 Shared libraries used by Subversio
ii libsvncpp3 0.12.0dfsg-2 Subversion C++ shared library
ii libuuid1 2.17.2-9 Universally Unique ID library
ii libwxbase2.8-0 2.8.10.1-3+b1 wxBase library (runtime) - non-GUI
ii libwxgtk2.8-0 2.8.10.1-3+b1 wxWidgets Cross-platform C++ GUI t
Versions of packages rapidsvn recommends:
ii ssh-askpass 1:1.2.4.1-9 under X, asks user for a passphras
rapidsvn suggests no packages.
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: rapidsvn
Source-Version: 0.12.0dfsg-6
We believe that the bug you reported is fixed in the latest version of
rapidsvn, which is due to be installed in the Debian FTP archive:
libsvncpp-dev_0.12.0dfsg-6_amd64.deb
to main/r/rapidsvn/libsvncpp-dev_0.12.0dfsg-6_amd64.deb
libsvncpp3_0.12.0dfsg-6_amd64.deb
to main/r/rapidsvn/libsvncpp3_0.12.0dfsg-6_amd64.deb
rapidsvn_0.12.0dfsg-6.debian.tar.gz
to main/r/rapidsvn/rapidsvn_0.12.0dfsg-6.debian.tar.gz
rapidsvn_0.12.0dfsg-6.dsc
to main/r/rapidsvn/rapidsvn_0.12.0dfsg-6.dsc
rapidsvn_0.12.0dfsg-6_amd64.deb
to main/r/rapidsvn/rapidsvn_0.12.0dfsg-6_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 644409@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
gregor herrmann <gregoa@debian.org> (supplier of updated rapidsvn package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 23 Jun 2012 16:53:59 +0200
Source: rapidsvn
Binary: rapidsvn libsvncpp3 libsvncpp-dev
Architecture: source amd64
Version: 0.12.0dfsg-6
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: gregor herrmann <gregoa@debian.org>
Description:
libsvncpp-dev - Subversion C++ library (development files)
libsvncpp3 - Subversion C++ shared library
rapidsvn - GUI client for Subversion
Closes: 644409 678556
Changes:
rapidsvn (0.12.0dfsg-6) unstable; urgency=low
.
* QA upload.
* Fix "rapidsvn SEGV with Subversion 1.7": apply slightly modified upstream
patch, thanks Philip Martin.
Additionally make runtime dependency of rapidsvn on libsvncpp3 versioned
to make sure a fixed libsvncpp3 gets pulled in.
(Closes: #644409)
* Fix "please drop Build-Depends: libserf-0-0-dev": do as the bug report
requests, thanks Peter Samuelson.
(Closes: #678556)
Checksums-Sha1:
f243fbbc7cae16f6b7599ecdbad7c6b3f0f00c13 1972 rapidsvn_0.12.0dfsg-6.dsc
160e2fec31b57c0ee94c120f3e51d8ba31084fa8 9265 rapidsvn_0.12.0dfsg-6.debian.tar.gz
c2daf7ebffb3d4bcb9c8f0f5a0df0f887edaf898 393822 rapidsvn_0.12.0dfsg-6_amd64.deb
1bd378dfb764504a2e57b0c469968b52a0148f59 67512 libsvncpp3_0.12.0dfsg-6_amd64.deb
7c6411cbfbfb2e4464da8ccb70a12cd1e4105263 312566 libsvncpp-dev_0.12.0dfsg-6_amd64.deb
Checksums-Sha256:
23f13fecffe398844a55e37abd25e760c8c3afd8e75831e5158dfc7e1f1df3ac 1972 rapidsvn_0.12.0dfsg-6.dsc
f5a0049a5f7b07c5cd084ce3a14aa5f9a3c4df497767492d75e88b0154a0f30e 9265 rapidsvn_0.12.0dfsg-6.debian.tar.gz
db0e6e2dc1da59b7249e57064b3dad12e00c3eede7690dd6fab242b1a39b2fed 393822 rapidsvn_0.12.0dfsg-6_amd64.deb
b290d23d05243ca460738bebf6a6e19e58a757708aba32c37202affb45f4c14d 67512 libsvncpp3_0.12.0dfsg-6_amd64.deb
5e1c26d053b9b837b1ab90813aefbf841e383ffcc57fbde34a13a7e391a83eef 312566 libsvncpp-dev_0.12.0dfsg-6_amd64.deb
Files:
e8d7259124b002717bcdf0982e16333e 1972 x11 optional rapidsvn_0.12.0dfsg-6.dsc
bab5d825572699708135d34a20365a2e 9265 x11 optional rapidsvn_0.12.0dfsg-6.debian.tar.gz
a38e0b4d48510a560d8adcb63913dcdf 393822 x11 optional rapidsvn_0.12.0dfsg-6_amd64.deb
77aa892e467bd62778f2ef1be16c1438 67512 libs optional libsvncpp3_0.12.0dfsg-6_amd64.deb
3b367c5f5a32ccd9e9788b3a2ee118e6 312566 libdevel optional libsvncpp-dev_0.12.0dfsg-6_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJP5dkYAAoJELs6aAGGSaoGnJMP/1zTq3X8V7w5qHn1rO/1ffXe
Xh76G9+keYbJrZLjdWkPve9rp+y2fMOln7GiuNPW6lMChePKmJ1nAosNqftA0ULm
e5guw3D10GWZjASfkAkgvKLl07x15s7vl5gT9RkBAw23Scy5IlCiZf/hiZ+3bNWs
qHYumJmA0vhPDDvzPvdHnO/EXTvFzMDu1P7QiXyZeBVnN61NOawLApL52zqFwYVE
cpVNqdrgOKS8EPFUhAjnfgkKEcwzG6LXGMKhkzJwbjoL3PQW+tXbodXfIZXfVRpt
NFB7XQSBg0pmxxGhavuvRhmFwXWcfn4tNOjRkdR86fhvDyp/k7LboNEpiKyW22EI
EaI1rz/fnVIRe4oelZZa0lLkYCSDkimYMpuLm2mXdSmlhII3p/rx/PhXmxlfsqEf
SOiF+PCjSGE45mm0eFGcDUJTusqXt1auV4qHv2H9uac/A+YMTJ4/gR7FuuglRWtq
x5eQV2/MO/66H61Gk0V6y9UdPIZ03qsdLWacyTd3IhJQVEPwvAK0Xu5Py+qZfL6F
qygTbvP3LgDukCVVB1MZdNr25ArSSHy8/ooQCfEGBMEG6dFpa+qkX7H0N/c4ShVX
2lwmin+gzoYHhWR9pDYSNSRerKOc/LcjahVg7wIRHrGXguhgrYQxasg1ZW0UpLdE
1nxTuNqQQb+6Qit8ctJH
=/DqX
-----END PGP SIGNATURE-----
--- End Message ---