[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#644647: marked as done (nethack-common.postinst creates record file in a way that doesn't work on some systems)

Your message dated Tue, 12 Jun 2012 10:03:12 +0000
with message-id <E1SeNwO-0005Xt-Bo@franck.debian.org>
and subject line Bug#644647: fixed in nethack 3.4.3-14
has caused the Debian Bug report #644647,
regarding nethack-common.postinst creates record file in a way that doesn't work on some systems
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

644647: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=644647
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: nethack-common
Version: 3.4.3-12.2
Severity: normal

Dear Maintainer,

In nethack-common.postinst, you try to create an empty
/var/games/nethack/record text file by using /dev/null as a source for
/usr/bin/install. The result of this on my busybox armel system is
that the new file is created as a character special block device, not
an ascii file. This means that the scorefile is not updated by nethack
(yet, there is no error displayed to the user...).

I noticed this because it affects my maemo port of your package, but I
expect this is true on other busybox systems (or possibly armel?)
running regular Debian. 

I've attached a suggested patch which seems to work on both my N900
and my amd64 sid system, creating the empty file with touch and then
setting the same mode and ownership you're using now.

Here is the strace that shows the file is a character special block

20364 open("/var/games/nethack/record", O_RDONLY) = 5
20364 fstat64(5, {st_mode=S_IFCHR|0664, st_rdev=makedev(1, 3), ...}) = 0
20364 ioctl(5, SNDCTL_TMR_TIMEBASE or TCGETS, 0xbed0c6a4) = -1 ENOTTY (Inappropriate ioctl for device)
20364 mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40021000
20364 read(5, "", 4096)                 = 0
20364 close(5)                          = 0
20364 munmap(0x40021000, 4096)          = 0
20364 open("/var/games/nethack/record", O_WRONLY|O_CREAT|O_TRUNC, 0666) = 5
20364 fstat64(5, {st_mode=S_IFCHR|0664, st_rdev=makedev(1, 3), ...}) = 0
20364 ioctl(5, SNDCTL_TMR_TIMEBASE or TCGETS, 0xbed0c27c) = -1 ENOTTY (Inappropriate ioctl for device)
20364 mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40021000
20364 write(5, "3.4.3 166 0 1 1 13 13 0 20111004"..., 74) = 74
20364 close(5)                          = 0
20364 munmap(0x40021000, 4096)          = 0
20364 unlink("/var/games/nethack/record_lock") = 0

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.0.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages nethack-common depends on:
ii  debconf [debconf-2.0]  1.5.41 
ii  debianutils            4.0.2  
ii  libc6                  2.13-21

Versions of packages nethack-common recommends:
ii  nethack-console  3.4.3-12.2

nethack-common suggests no packages.

-- debconf information:
  nethack-common/recover-setgid: false
  nethack-common/backup-incompatible: backup
--- nethack-common.postinst	2011-10-07 13:58:36.000000000 -0400
+++ /var/chroot/sid-ia32/scratchbox/users/johnsu01/home/johnsu01/nethack-3.4.3/debian/nethack-common.postinst	2011-10-07 14:02:10.000000000 -0400
@@ -50,7 +50,9 @@
     for file in perm record logfile; do
       if [ ! -e /var/games/nethack/$file ]; then
-	  	install -m 0664 -o root -g games /dev/null /var/games/nethack/$file
+		touch /var/games/nethack/$file
+		chmod 0664 /var/games/nethack/$file
+		chown root:games /var/games/nethack/$file

--- End Message ---
--- Begin Message ---
Source: nethack
Source-Version: 3.4.3-14

We believe that the bug you reported is fixed in the latest version of
nethack, which is due to be installed in the Debian FTP archive:

  to main/n/nethack/nethack-common_3.4.3-14_amd64.deb
  to main/n/nethack/nethack-console_3.4.3-14_amd64.deb
  to main/n/nethack/nethack-lisp_3.4.3-14_amd64.deb
  to main/n/nethack/nethack-x11_3.4.3-14_amd64.deb
  to main/n/nethack/nethack_3.4.3-14.debian.tar.gz
  to main/n/nethack/nethack_3.4.3-14.dsc

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 644647@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Vincent Cheng <Vincentc1208@gmail.com> (supplier of updated nethack package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA256

Format: 1.8
Date: Mon, 11 Jun 2012 00:47:38 -0700
Source: nethack
Binary: nethack-common nethack-console nethack-lisp nethack-x11
Architecture: source amd64
Version: 3.4.3-14
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Vincent Cheng <Vincentc1208@gmail.com>
 nethack-common - dungeon crawl game - common files
 nethack-console - dungeon crawl game - text-based interface
 nethack-lisp - dungeon crawl game - Lisp interface
 nethack-x11 - dungeon crawl game - X11 interface
Closes: 329318 644647 673584
 nethack (3.4.3-14) unstable; urgency=low
   * Team upload.
   [ Bernhard R. Link ]
   * switch to "3.0 (quilt)"
   * bump Standards-Version
   * modernize debian/rules:
   - use dpkg-buildflags
   - support build-arch/-indep
   - make parallel safe
   - don't avoid make errors
   * add patch so it can compile with -Werror=format-security
   * drop no longer needed patches (-qt and -gnome are gone)
   * don't use /dev/null as install template (Closes: 644647)
   * drop nethack-common menu (both -console and -x11 have one)
   [ Vincent Cheng ]
   * Adopt package. (Closes: #673584)
     - Change Maintainer to Debian Games Team.
     - Add myself to Uploaders.
   * Modify 0006-Common-config.h-for-all-binary-packages.patch to enable
     AUTOPICKUP_EXCEPTIONS. (Closes: #329318)
   * Modify 0011-Pasi-Kallinen-s-patch-to-add-colors-to-inventory-ite.patch
     and 0017-Debian-and-Linux-specifics-defined-in-unixconf.h.patch; add
     0021-fix-kfreebsd-ftbfs.patch to fix FTBFS on kfreebsd.
   * Convert debian/copyright to DEP-5 machine-readable format.
   * Use dh_lintian to install overrides instead of manually installing them
     in debian/rules.
   * Add watch file.
   * Add Homepage field in debian/control.
   * Add Vcs-* fields in debian/control.
 653778dbb4f90d4cfd5e8c387f50cf251714dc1b 2247 nethack_3.4.3-14.dsc
 831794a15a96e2f2d8be12322daeb34b09354745 123103 nethack_3.4.3-14.debian.tar.gz
 f26113677e753437a1417805e128af7ae4eb4ef1 467554 nethack-common_3.4.3-14_amd64.deb
 1afa27e2337d8cf340771ed959651400fb77f2d5 958792 nethack-console_3.4.3-14_amd64.deb
 20c7174d27690200fdebad3f723bf03049a76e1f 948844 nethack-lisp_3.4.3-14_amd64.deb
 2154c5f15fe99796430be3559facf36dbe851dcd 1011832 nethack-x11_3.4.3-14_amd64.deb
 472ba4002334fcc4cf963631c4111eb15166d1f725e37a1165efaf7ae2b74ea8 2247 nethack_3.4.3-14.dsc
 13f118213353e18acf21f8799663c51d5ac46d6fadf8a223ff80911d79b321be 123103 nethack_3.4.3-14.debian.tar.gz
 075be9fe69a0782498e0cbe50b1f4a6e464434592102c9a437ee38fcfb47ee9f 467554 nethack-common_3.4.3-14_amd64.deb
 a352c400c569d02af1e3e462e3c5f4aad3775907900764cc328c588ec1016637 958792 nethack-console_3.4.3-14_amd64.deb
 58e03825890dd4a5e5d38a53b6b670a1abb12a06281d0e9a2164a92a6a15a50b 948844 nethack-lisp_3.4.3-14_amd64.deb
 a680be5ff2cb24b792a2a8a059975fe21f6009511615a410d075dd4a65f11413 1011832 nethack-x11_3.4.3-14_amd64.deb
 3b51030e0130118c8de7068a49650937 2247 games optional nethack_3.4.3-14.dsc
 affa84e2f4566c1c16a86b1dcff633ff 123103 games optional nethack_3.4.3-14.debian.tar.gz
 b2706c124a27aca72b6b0dbaafc1c8ee 467554 games optional nethack-common_3.4.3-14_amd64.deb
 12ce12e5bf29f55003a62f828b4850a4 958792 games optional nethack-console_3.4.3-14_amd64.deb
 dea3e964a916d8cd2bbb7502474fa420 948844 games optional nethack-lisp_3.4.3-14_amd64.deb
 da90890f52cccb404fcdedee84d4a443 1011832 games optional nethack-x11_3.4.3-14_amd64.deb

Version: GnuPG v1.4.12 (GNU/Linux)


--- End Message ---

Reply to: