Bug#663747: FTBFS with LibreOffice 3.5: basis-link gone/uninstallable with LibreOffice 3.5

[Rene Engelhard <rene@debian.org>]

Package: openclipart
Version: 2.0-1
Severity: important
Tags: patch

Hi,

I already fixed this in 0.18+dfsg-13 in experimental[1], which is now void
with your 2.0-1 upload to unstable. (-13 will get removed because it's lower
than unstable and apt will prefer 2.0-1 anyway)

LibreOffice 3.5 dropped the "we change basisX.Y with every minor version"
madness and thus also dropped basis-link. Which leads to the jodconverter
build not being able to have the Java classes of LO acctually available.

Besides that, this package even will get uninstallable when LibreOffice 3.5
enters sid.

Filing this as important for now but this bug will become serious when LibreOffice
3.5.x gets uploaded to sid (and this *will* happen before the wheezy freeze)

What I did from -12 to -13 is:

diff -u openclipart-0.18+dfsg/debian/rules openclipart-0.18+dfsg/debian/rules
--- openclipart-0.18+dfsg/debian/rules
+++ openclipart-0.18+dfsg/debian/rules
@@ -81,7 +81,7 @@

        # Create OOo gallery files; we need to add the files in hunks
        # because we othererwise may get too many arguments....
-       mkdir -p $(CURDIR)/build/usr/lib/libreoffice/$(shell readlink /usr/lib/libreoffice/basis-link)/share/gallery
+       mkdir -p $(CURDIR)/build/usr/lib/libreoffice/share/gallery
        for dir in `find build/usr/share/openclipart/png -mindepth 1 -maxdepth 1 -type d | LC_CTYPE=C sort` ; do \
                gal_name=$${dir##*/}; \
                gal_oooname=`echo $$gal_name | awk '{gsub("_"," ");a=toupper(substr($$0,1,1));b=substr($$0,2);print a b}'` ; \
@@ -90,7 +90,7 @@
                split -d -l 250 build/$$gal_name.filelist build/$$gal_name.filelist- ; \
                for file in build/$$gal_name.filelist-*; do \
                        echo "Processing filelist $$file"; \
-                       SAL_USE_VCLPLUGIN="svp" /usr/lib/libreoffice/basis-link/program/gengal --name "$$gal_oooname" --path "$(CURDIR)/build/usr/lib/libreoffice/`readlink /usr/lib/libreoffice/basis-link`/share/gallery" --destdir "$(CURDIR)/build" --number-from "70" `cat $$file | xargs`; \
+                       SAL_USE_VCLPLUGIN="svp" /usr/lib/libreoffice/program/gengal --name "$$gal_oooname" --path "$(CURDIR)/build/usr/lib/libreoffice/share/gallery" --destdir "$(CURDIR)/build" --number-from "70" `cat $$file | xargs`; \
                done; \
        done

@@ -111,9 +111,9 @@
                $(CURDIR)/debian/openclipart-svg/usr/share/openclipart/svg/

        # Install OOo files
-       mkdir -p $(CURDIR)/debian/openclipart-libreoffice/usr/lib/libreoffice/$(shell readlink /usr/lib/libreoffice/basis-link)/share/gallery
-       cp -af $(CURDIR)/build/usr/lib/libreoffice/$(shell readlink /usr/lib/libreoffice/basis-link)/share/gallery/* \
-               $(CURDIR)/debian/openclipart-libreoffice/usr/lib/libreoffice/$(shell readlink /usr/lib/libreoffice/basis-link)/share/gallery/
+       mkdir -p $(CURDIR)/debian/openclipart-libreoffice/usr/lib/libreoffice/share/gallery
+       cp -af $(CURDIR)/build/usr/lib/libreoffice/share/gallery/* \
+               $(CURDIR)/debian/openclipart-libreoffice/usr/lib/libreoffice/share/gallery/

        # Install Overrides file
        install -p -o root -g root -m 644 $(CURDIR)/debian/openclipart-svg.overrides $(CURDIR)/debian/openclipart-svg/usr/share/lintian/overrides/openclipart-svg
@@ -143,7 +143,7 @@
@@ -143,7 +143,7 @@
        dh_installdeb
 #      dh_perl
        dh_shlibdeps
-       dh_gencontrol -- -V'basis-version=$(shell readlink /usr/lib/libreoffice/basis-link | sed -e "s/basis//")'
+       dh_gencontrol
        dh_md5sums
        dh_builddeb

diff -u openclipart-0.18+dfsg/debian/changelog openclipart-0.18+dfsg/debian/changelog
--- openclipart-0.18+dfsg/debian/changelog
+++ openclipart-0.18+dfsg/debian/changelog
@@ -1,3 +1,11 @@
+openclipart (0.18+dfsg-13) experimental; urgency=low
+
+  * QA upload
+  * adapt for basisX.Y / basis-link removal in LibreOffice 3.5
+  * rebuild for LibreOffice >= 3.5
+
+ -- Rene Engelhard <rene@debian.org>  Mon, 13 Feb 2012 23:11:07 +0000
+
 openclipart (0.18+dfsg-12) unstable; urgency=low

   * QA upload
diff -u openclipart-0.18+dfsg/debian/control openclipart-0.18+dfsg/debian/control
--- openclipart-0.18+dfsg/debian/control
+++ openclipart-0.18+dfsg/debian/control
@@ -45,7 +45,7 @@
 Package: openclipart-libreoffice
 Architecture: all
 Depends: ${shlibs:Depends}, ${misc:Depends}, openclipart-png (= ${Source-Version})
-Conflicts: openclipart (<< 0.10+dfsg-3), libreoffice-common (<< 1:${basis-version}), libreoffice-common (>= 1:${basis-version}.99)
+Conflicts: openclipart (<< 0.10+dfsg-3), libreoffice-common (<< 1:3.5.0~beta~)
 Recommends: libreoffice
 Description: clip art for OpenOffice.org/LibreOffice gallery
  The Open Clip Art Library is a collection of 100% license-free,

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Grüße/Regards,

Rene

[1] and you even missed -12, but that happily only was a simple rebuild so this
upload should have worked. Bad nevertheless.