[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#461006: marked as done (smarty passes arrays to default modifiers instead of strings)

Your message dated Sun, 04 Mar 2012 11:08:13 +0000
with message-id <[🔎] E1S49IT-0005CW-Mh@franck.debian.org>
and subject line Bug#592797: Removed package(s) from unstable
has caused the Debian Bug report #461006,
regarding smarty passes arrays to default modifiers instead of strings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
461006: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=461006
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: smarty
Version: 2.6.18-1
Severity: important

I wanted to make my smarty templates secure by default, but smarty seems
to prevent me from doing so.

I'm doing this:

$smarty->default_modifiers = array("escape:'htmlall'");

$smarty->assign('paras',
	array(
		array('heading'=>'head 1','text'=>'text 1'),
		array('heading'=>'head 2','text'=>'text 2')
	)
);

And putting this in the template:

{foreach from=$paras item="para" key="para_id"}
<h1>{$para.heading}</h1>
{$para.text}
{/foreach}

And I get this twice:

Warning: htmlentities() expects parameter 1 to be string, array given
in /usr/share/php/smarty/libs/plugins/modifier.escape.php on line 29

Modifying modifier.escape.php indicates that smarty is passing the value
of $para to the default modifier functions instead of passing the values
of $para['heading'] and para['text'] to the default modifier functions. 

If I turn off default_modifiers and manually add escapes to each
variable, everything is fine.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.23-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages smarty depends on:
ii  php5                          5.2.4-2    server-side, HTML-embedded scripti
ii  php5-cgi                      5.2.4-2+b1 server-side, HTML-embedded scripti
ii  php5-cli                      5.2.4-2+b1 command-line interpreter for the p

-- 
bye,
pabs

http://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message --- 
Version: 2.6.26-0.2+rm

Dear submitter,

as the package smarty has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see http://bugs.debian.org/592797

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@debian.org.

Debian distribution maintenance software
pp.
Joerg Jaspert (the ftpmaster behind the curtain)

--- End Message ---
Reply to: