Bug#643390: glabels: FTBFS: plessey.c:151:9: error: format not a string literal and no format arguments [-Werror=format-security]
Source: glabels
Version: 2.2.8-2
Severity: serious
Tags: wheezy sid
User: debian-qa@lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64
Hi,
During a rebuild of all packages in sid, your package failed to build on
amd64.
Relevant part:
> /bin/bash ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -pthread -DORBIT2=1 -D_REENTRANT -DCAMEL_HAVE_NSS -DCAMEL_HAVE_SSL -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gail-1.0 -I/usr/include/nss -I/usr/include/nspr -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/libgnome-2.0 -I/usr/include/orbit-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/evolution-data-server-3.0 -I/usr/include/libsoup-2.4 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c -o plessey.lo plessey.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -pthread -DORBIT2=1 -D_REENTRANT -DCAMEL_HAVE_NSS -DCAMEL_HAVE_SSL -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gail-1.0 -I/usr/include/nss -I/usr/include/nspr -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/libgnome-2.0 -I/usr/include/orbit-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/evolution-data-server-3.0 -I/usr/include/libsoup-2.4 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c plessey.c -fPIC -DPIC -o .libs/plessey.o
> plessey.c: In function 'Barcode_pls_verify':
> plessey.c:48:5: warning: pointer targets in passing argument 1 of 'strlen' differ in signedness [-Wpointer-sign]
> /usr/include/string.h:399:15: note: expected 'const char *' but argument is of type 'unsigned char *'
> plessey.c: In function 'Barcode_pls_encode':
> plessey.c:151:9: error: format not a string literal and no format arguments [-Werror=format-security]
> cc1: some warnings being treated as errors
>
> make[3]: *** [plessey.lo] Error 1
The full build log is available from:
http://people.debian.org/~lucas/logs/2011/09/23/glabels_2.2.8-2_lsid64.buildlog
This happened because since dpkg 1.16.0 [0], hardening flags are enabled
under various conditions.
[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot. Internet was not
accessible from the build systems.
Reply to: