[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#647473: question about your patch



On Sun, Nov 6, 2011 at 6:23 AM, Holger Levsen <holger@layer-acht.org> wrote:
> Hi Dave,
>
...> +
> +if [ "$1" = "remove" ]
> +then
> +    rm -f /etc/xml/sgml-data.xml* || :
> +    rm -f /etc/sgml/sgml-data* || :
>  fi
>
>
> This patch seems to remove configuration files unconditionally on "remove".
> This seems wrong to me. Can you explain?
...

After sgml-data installation, the following files appear under /etc:

    /etc/xml/sgml-data.xml
    /etc/xml/sgml-data.xml.bak
    /etc/sgml/sgml-data.cat
    /etc/sgml/sgml-data.cat.old

Upon removal, the last 3 remain, and ultimately cause the piuparts
failure. So, when removing the sgml-data package, I am removing
sgml-data files from etc.

Are you suggesting that i shouldn't use the wildcards? if not, what is
the issue?



Reply to: