Bug#638336: gecko-mediaplayer: build-arch does not build architecture-dependent part
Source: gecko-mediaplayer
Version: 1.0.4-1
Severity: important
Justification: policy §4.9
Tags: patch
Hi,
As policy §4.9 says,
The build-arch target, if provided, should perform all the
configuration and compilation required for producing all
architecture-dependant binary packages
In particular, in this package it should not be empty. How about this
patch?
---
debian/changelog | 8 ++++++++
debian/rules | 13 ++++++-------
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 959000c7..51139d12 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+gecko-mediaplayer (1.0.4-2.1) local; urgency=low
+
+ * debian/rules:
+ - Mark build-arch and build-indep targets phony.
+ - Make build-arch target actually build the architecture-dependent part
+ of the package so the build does not run with (fake) root privileges
+ when autobuilders start to use it.
+ - binary-arch and binary-indep depend on build-arch and build-indep,
+ respectively, to save arch-all builds some time.
+
+ -- Jonathan Nieder <jrnieder@gmail.com> Thu, 18 Aug 2011 12:51:21 -0500
+
gecko-mediaplayer (1.0.4-2) unstable; urgency=high
* QA upload.
diff --git a/debian/rules b/debian/rules
index b74e0b4b..9514f966 100755
--- a/debian/rules
+++ b/debian/rules
@@ -36,8 +36,7 @@ configure-stamp:
touch configure-stamp
-build: build-stamp
-
+build-arch: build-stamp
build-stamp: configure-stamp
dh_testdir
@@ -67,11 +66,9 @@ install: build
rm -rf $(CURDIR)/debian/gecko-mediaplayer/usr/share/doc/gecko-mediaplayer
build-indep:
-build-arch:
-
-binary-indep: build install
+binary-indep: build-indep
-binary-arch: build install
+binary-arch: build-arch install
dh_testdir
dh_testroot
dh_installchangelogs ChangeLog
@@ -87,5 +84,7 @@ binary-arch: build install
dh_md5sums
dh_builddeb
+build: build-indep build-arch
binary: binary-indep binary-arch
-.PHONY: build clean binary-indep binary-arch binary install configure
+.PHONY: build-indep build-arch build binary-indep binary-arch binary
+.PHONY: clean install configure
--
1.7.6
Reply to: