[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#632562: marked as done (trophy: FTBFS with ld --as-needed)



Your message dated Wed, 06 Jul 2011 06:32:40 +0000
with message-id <E1QeLf6-0001KW-7t@franck.debian.org>
and subject line Bug#632562: fixed in trophy 1.1.7-1
has caused the Debian Bug report #632562,
regarding trophy: FTBFS with ld --as-needed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
632562: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632562
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: trophy
Version: 1.1.6-3
Severity: normal
Tags: upstream patch
User: debian-gcc@lists.debian.org
Usertags: ld-as-needed

The package fails to build when --as-needed linker option is enabled,
because of incorrect order of parameters passed to ld. Here's a log of
failed build in Ubuntu:
https://launchpadlibrarian.net/70927222/buildlog_ubuntu-oneiric-i386.trophy_1.1.6-3_FAILEDTOBUILD.txt.gz

See also
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The attached patch was used in Ubuntu to fix the problem.
https://launchpad.net/ubuntu/+source/trophy/1.1.6-3ubuntu1

-- System Information:
Debian Release: wheezy/sid
  APT prefers oneiric
  APT policy: (500, 'oneiric')
Architecture: i386 (i686)

Kernel: Linux 2.6.38-10-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
Description: Place libaries in another variable to fix build problem with
 --as-needed linker option.
Author: Ilya Barygin <barygin@gmail.com>
Bug-Ubuntu: https://launchpad.net/bugs/803207

--- trophy-1.1.6.orig/src/Makefile.am
+++ trophy-1.1.6/src/Makefile.am
@@ -13,6 +13,6 @@ trophy_SOURCES = cagoody.cpp cainfodialo
 		 caslotselectiondialog.h
 
 CLANLIB_MODULES = clanSignals-1.0 clanGL-1.0 clanCore-1.0 clanSound-1.0 clanDisplay-1.0 clanApp-1.0
-AM_LDFLAGS = `pkg-config --libs $(CLANLIB_MODULES)`
+LIBS += `pkg-config --libs $(CLANLIB_MODULES)`
 INCLUDES = `pkg-config --cflags $(CLANLIB_MODULES)`
 AM_CPPFLAGS = -DPKGDATADIR=\"$(pkgdatadir)\"
--- trophy-1.1.6.orig/src/Makefile.in
+++ trophy-1.1.6/src/Makefile.in
@@ -177,7 +177,7 @@ trophy_SOURCES = cagoody.cpp cainfodialo
 		 caslotselectiondialog.cpp cafogbomb.h caimageview.h camenu.cpp canetclient.h capositiontable.cpp \
 		 caslotselectiondialog.h
 
-AM_LDFLAGS = `pkg-config --libs $(CLANLIB_MODULES)`
+LIBS += `pkg-config --libs $(CLANLIB_MODULES)`
 INCLUDES = `pkg-config --cflags $(CLANLIB_MODULES)`
 AM_CPPFLAGS = -DPKGDATADIR=\"$(pkgdatadir)\"
 all: all-am

--- End Message ---
--- Begin Message ---
Source: trophy
Source-Version: 1.1.7-1

We believe that the bug you reported is fixed in the latest version of
trophy, which is due to be installed in the Debian FTP archive:

trophy-data_1.1.7-1_all.deb
  to main/t/trophy/trophy-data_1.1.7-1_all.deb
trophy-dbg_1.1.7-1_amd64.deb
  to main/t/trophy/trophy-dbg_1.1.7-1_amd64.deb
trophy_1.1.7-1.debian.tar.gz
  to main/t/trophy/trophy_1.1.7-1.debian.tar.gz
trophy_1.1.7-1.dsc
  to main/t/trophy/trophy_1.1.7-1.dsc
trophy_1.1.7-1_amd64.deb
  to main/t/trophy/trophy_1.1.7-1_amd64.deb
trophy_1.1.7.orig.tar.gz
  to main/t/trophy/trophy_1.1.7.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 632562@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Moog <amoog@ubuntu.com> (supplier of updated trophy package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 03 Jul 2011 18:28:57 +0200
Source: trophy
Binary: trophy trophy-dbg trophy-data
Architecture: source amd64 all
Version: 1.1.7-1
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Andreas Moog <amoog@ubuntu.com>
Description: 
 trophy     - 2D car racing action game
 trophy-data - 2D car racing action game (data files)
 trophy-dbg - 2D car racing action game (debugging symbols)
Closes: 622168 632562
Changes: 
 trophy (1.1.7-1) unstable; urgency=low
 .
   * New Maintainer (Closes: #622168)
   * New Upstream Release
   * Drop 01-build_against_clanlib_1.0.patch, included upstream
   * Add d/p/use-pkgconfig and build with dh-autoreconf to fix issues
     with ld --as-needed (Closes: #632562)
   * Switch debian/copyright to use DEP5 format
Checksums-Sha1: 
 8135ee2f747de3423c404001bc466321125a2fb9 1348 trophy_1.1.7-1.dsc
 a74d3de62048353b31f95772c5f92ef9996d573f 14406657 trophy_1.1.7.orig.tar.gz
 cb38087eea18ac8433c3654a8ec70d88f0ec47b6 7595 trophy_1.1.7-1.debian.tar.gz
 e59a42d6966e1e1d31ebee9e32f9905ade354101 77012 trophy_1.1.7-1_amd64.deb
 f268176f1be845b12d6ce9c4e8b1c95c265c15b5 1445948 trophy-dbg_1.1.7-1_amd64.deb
 6ef1663bae9aabc1c123fe2c1816fd48d41165a0 14237658 trophy-data_1.1.7-1_all.deb
Checksums-Sha256: 
 f5be7d3a75a13a7f6ba8689874451dd24ff72a8ec47af61902d1acb449465e6f 1348 trophy_1.1.7-1.dsc
 365b419e84cc980c39b6cf01fa2b5b2ea944a5c9373304e5c93b2d57c0d36ef3 14406657 trophy_1.1.7.orig.tar.gz
 d0c09ef90fba19bd45913d355132357330816243337dc3caa7ebca7bad364d3c 7595 trophy_1.1.7-1.debian.tar.gz
 dec0a5424041967c9586a1ee85aa52fe3f6a95774470d357cb7d0958e3fa8111 77012 trophy_1.1.7-1_amd64.deb
 51b94ee5776afe6d6fad601f007d8f897d5e87e18d138c3ee9c4d16b4a4bdf0a 1445948 trophy-dbg_1.1.7-1_amd64.deb
 240ec49493070e8285e84c4409fe814260370b0e522e0e205fc1fca8d40513cf 14237658 trophy-data_1.1.7-1_all.deb
Files: 
 d2701a14e928c82187c3e36c0f242c87 1348 games optional trophy_1.1.7-1.dsc
 09da49ebb669801613b9442fb1cb6768 14406657 games optional trophy_1.1.7.orig.tar.gz
 2e2b645fa0620b35ecfdd969d7bc22ba 7595 games optional trophy_1.1.7-1.debian.tar.gz
 7ae444845f9936df0298f2c002772885 77012 games optional trophy_1.1.7-1_amd64.deb
 05458e9a068507b2b6b86787130318c2 1445948 debug extra trophy-dbg_1.1.7-1_amd64.deb
 fe67e9fc1345691852ba0fa5cd6102fe 14237658 games optional trophy-data_1.1.7-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFOFAA0vdkzt4X+wX8RAtf0AJ4vHIKStfkEjb4voG7ooBQnRkRjWgCfSB+g
/4cSmzI/uxY+ZfwTOI/oCaw=
=h4f6
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: