[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#548353: marked as done (worklog: formatting error if the delta_time == 0)

Your message dated Wed, 1 Jun 2011 16:25:23 -0400 (EDT)
with message-id <alpine.DEB.2.00.1106011624330.29235@orange.limedaley.com>
and subject line Obsolete
has caused the Debian Bug report #548353,
regarding worklog: formatting error if the delta_time == 0
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

548353: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=548353
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: worklog
Version: 1.8-4
Severity: minor
Tags: patch

There is a bug when delta=0 (granted, hard to ever get to) but the output is wrong, and 
it is a trival fix. If this fix isn't applied, the temps string for the start of the 
line is also used within the brackets

Modified: vendor/worklog/mine/worklog.c
--- vendor/worklog/mine/worklog.c       2009-09-25 18:10:14 UTC (rev 9553)
+++ vendor/worklog/mine/worklog.c       2009-09-25 18:12:06 UTC (rev 9554)
@@ -629,6 +629,11 @@
+            else
+            {
+                    // make sure to always set temps
+                sprintf(temps,"0.00 seconds") ;
+            }
             fprintf(f,": %s : finished ",temps) ;
             fprintf(fa," : [%s] : finished ",temps) ;
             time(&t) ;

-- System Information:
Debian Release: 5.0.3
  APT prefers proposed-updates
  APT policy: (500, 'proposed-updates'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/2 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/bash

Versions of packages worklog depends on:
ii  libc6                     2.7-18         GNU C Library: Shared libraries
ii  libncurses5               5.7+20081213-1 shared libraries for terminal hand

worklog recommends no packages.

worklog suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message --- Bug #571718 has a patch that obsoletes this patch, so it isn't needed any more.

Jon Daley
Aim low; reach your goals, avoid disappointment

--- End Message ---

Reply to: