[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#579557: marked as done (XFig.pm: incorrect sample code in documentation, $fig->{'object'} is not numeric)

Your message dated Mon, 28 Feb 2011 22:54:22 +0000
with message-id <[🔎] E1PuByw-0006hJ-Hr@franck.debian.org>
and subject line Bug#615639: Removed package(s) from unstable
has caused the Debian Bug report #579557,
regarding XFig.pm: incorrect sample code in documentation, $fig->{'object'} is not numeric
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
579557: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579557
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fig2sty
Version: 1:0.1-12
Severity: minor

POD of Xfig.pm writes in the synopsys:

 # Parse a Fig file

 $fig->parsefile($figname);
 die "Can't read file $figname" if ($fig->{'object'} < 0);

However $fig->{'object'} is numeric (i.e. -1) in case of error only.
Otherwise it may be one of 'color', 'ellipse', 'polyline', 'spline',
'text', 'arc' or 'compund'.

Unfortunately usage the above example code produces a warning
if parsefile() method is executed succesfully and Perl runs with
warnings enabled. It is like this:

 Argument "compound" isn't numeric in numeric lt (<) at ...

Returning undef in case of error would be much more perlish
but there is no way to change the return value of -1 without
breaking existing programs.

A new error indicator is required,
or at least the documentation should be fixed somehow e.g.

 $fig->parsefile($figname);
 die "Can't read file $figname" if $fig->{'object'} !~ /^\w+$/;

Gabor


-- System Information:
Debian Release: 5.0.4
  APT prefers stable
  APT policy: (700, 'stable'), (500, 'proposed-updates')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/2 CPU cores)
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/bash

Versions of packages fig2sty depends on:
ii  perl                     5.10.0-19lenny2 Larry Wall's Practical Extraction 

fig2sty recommends no packages.

fig2sty suggests no packages.

-- debconf-show failed

--- End Message ---
--- Begin Message --- 
Version: 1:0.1-14+rm

Dear submitter,

as the package fig2sty has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see http://bugs.debian.org/615639

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@debian.org.

Debian distribution maintenance software
pp.
Luca Falavigna (the ftpmaster behind the curtain)

--- End Message ---
Reply to: