[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#611175: zsh: VCS_INFO wrongly detects svn repositories

Lennart Weller wrote:
> Currently zshs VCS_INFO function wrongly detects svn repositories if
> an .svn directory exists in the current path. Which also applies to
> home directories containing for example a ~/.svn/authors file.

That's a good point...

> Instead of checking only for the directory it would be smarter to
> check for an important svn repository file.  Like .svn/entries. Which
> is done through my patch.

That sounds reasonable. Do you know how stable the "entries" file is
within the .svn directories with respect to versions? Ie. Does it exist
in old versions as well as in recent ones? (My knowledge of subversion's
directory contents are rather limited.)

> I suggest to check the other revison control systems as well.

The other backends should not suffer from this problems. All others that
look for a directory to detect a VCS already look for a file in addition
to the directory. I don't remember why we didn't do this for svn
earlier, too. Probably because nobody complained. :)

Regards, Frank

In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925

Reply to: