[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#546261: marked as done (d4x: Fixed FTFBS due to conversion from "const char*" to "char*")

Your message dated Fri, 05 Feb 2010 15:33:16 +0000
with message-id <E1NdQBI-0006Kt-6L@ries.debian.org>
and subject line Bug#546261: fixed in d4x 2.5.7.1-7
has caused the Debian Bug report #546261,
regarding d4x: Fixed FTFBS due to conversion from "const char*" to "char*"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
546261: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=546261
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Subject: d4x: Fixed FTFBS due to conversion from "const char*" to "char*"
Package: d4x
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu karmic ubuntu-patch
Version: 2.5.7.1-6
Severity: wishlist
Tags: patch

This patch makes the package build also on newer version of g++ which
forbid a conversion from "const char*" to "char*".


In Ubuntu, we've applied the attached patch to achieve the following:

  * main/ftp.cc, main/html.cc, main/locstr.cc,
    main/face/edit.cc:
    - Fixed FTBFS due to conversion from const char* to char* (LP: #428207)

We thought you might be interested in doing the same.


-- System Information:
Debian Release: 5.0
  APT prefers jaunty-updates
APT policy: (500, 'jaunty-updates'), (500, 'jaunty-security'), (500, 'jaunty-backports'), (500, 'jaunty') 
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.28-15-generic (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

--- d4x-2.5.7.1.orig/main/ftp.cc
+++ d4x-2.5.7.1/main/ftp.cc
@@ -261,7 +261,7 @@
 };
 
 static void d4x_ftp_parse_pasv(const char *str,int args[]){
-	char *a=index(str,'(');
+	char *a=(char*)index(str,'(');
 	if (a==NULL) return;
 	a+=1;
 	int i=0;
only in patch2:
unchanged:
--- d4x-2.5.7.1.orig/main/html.cc
+++ d4x-2.5.7.1/main/html.cc
@@ -700,7 +700,7 @@
 
 void tHtmlParser::set_content_type(const char *ct){
 	//Example: text/html; charset=koi8-r
-	char *a=index(ct,'=');
+	const char *a=index(ct,'=');
 	if (a) codepage=a+1;
 };
 
only in patch2:
unchanged:
--- d4x-2.5.7.1.orig/main/locstr.cc
+++ d4x-2.5.7.1/main/locstr.cc
@@ -281,7 +281,7 @@
 	DBC_RETVAL_IF_FAIL(str!=NULL,NULL);
 	DBC_RETVAL_IF_FAIL(what!=NULL,NULL);
 	while (*str){
-		char *a=index(what,*str);
+		const char *a=index(what,*str);
 		if (a) return(str);
 		str++;
 	};
@@ -472,7 +472,7 @@
 char *escape_char(const char *where,char what,char bywhat){
 	DBC_RETVAL_IF_FAIL(where!=NULL,NULL);
 	int num=0;
-	char *tmp=index(where,what);
+	const char *tmp=index(where,what);
 	while(tmp){
 		num+=1;
 		tmp=index(tmp+1,what);
@@ -962,17 +962,17 @@
 	DBC_RETVAL_IF_FAIL(a!=NULL,NULL);
 	DBC_RETVAL_IF_FAIL(b!=NULL,NULL);
 	int i=0;
-	char *temp=index(b,'/');
+	char *temp=(char*)index(b,'/');
 	while (temp){
 		while (*temp=='/') temp+=1;
 		temp=index(temp,'/');
 		i+=1;
 	};
 	i-=1;
-	temp=rindex(a,'/');
+	temp=(char*)rindex(a,'/');
 	while (temp && i>0){
 		*temp=0;
-		char *tmp=rindex(a,'/');
+		char *tmp=(char*)rindex(a,'/');
 		*temp='/';
 		temp=tmp;
 		i-=1;
only in patch2:
unchanged:
--- d4x-2.5.7.1.orig/main/face/edit.cc
+++ d4x-2.5.7.1/main/face/edit.cc
@@ -1450,7 +1450,7 @@
 
 static void _proxy_port_changed_(GtkEntry *entry,GtkEntry *entryh){
 	const char *tmp=gtk_entry_get_text(entryh);
-	char *tmp1=index(tmp,':');
+	char *tmp1=(char *)index(tmp,':');
 	if (tmp1){
 		*tmp1=0;
 		char *ns=sum_strings(tmp,":",gtk_entry_get_text(entry),NULL);

--- End Message ---
--- Begin Message --- 
Source: d4x
Source-Version: 2.5.7.1-7

We believe that the bug you reported is fixed in the latest version of
d4x, which is due to be installed in the Debian FTP archive:

d4x-common_2.5.7.1-7_all.deb
  to main/d/d4x/d4x-common_2.5.7.1-7_all.deb
d4x_2.5.7.1-7.diff.gz
  to main/d/d4x/d4x_2.5.7.1-7.diff.gz
d4x_2.5.7.1-7.dsc
  to main/d/d4x/d4x_2.5.7.1-7.dsc
d4x_2.5.7.1-7_amd64.deb
  to main/d/d4x/d4x_2.5.7.1-7_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 546261@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mehdi Dogguy <mehdi@debian.org> (supplier of updated d4x package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 05 Feb 2010 15:56:59 +0100
Source: d4x
Binary: d4x d4x-common
Architecture: source all amd64
Version: 2.5.7.1-7
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Mehdi Dogguy <mehdi@debian.org>
Description: 
 d4x        - graphical download manager
 d4x-common - graphical download manager - common files
Closes: 546261 560490
Changes: 
 d4x (2.5.7.1-7) unstable; urgency=low
 .
   * QA upload.
   * Fix FTBFS due to invalid conversion from "const char*" to "char*"
     (Closes: #560490, #546261)
Checksums-Sha1: 
 4d1690c80acd22568d3106a56b1dab81df4c670d 1736 d4x_2.5.7.1-7.dsc
 2b86f75a534f0667e8cdffea3147af348fee101c 44158 d4x_2.5.7.1-7.diff.gz
 ce4690abf49175075ec9233c72d48cfcf7a126ac 672894 d4x-common_2.5.7.1-7_all.deb
 270a06cf77771285a92076546a4b038edd543134 731840 d4x_2.5.7.1-7_amd64.deb
Checksums-Sha256: 
 690e0e13e933b5d0b756c9ddc9e10df850882aa3e244b6da6a01ef2f1cc99a69 1736 d4x_2.5.7.1-7.dsc
 9ce5b0c8d0ca8d6dd2ee0a10d65b8307362841d058a4f2eefc5cf19394100de0 44158 d4x_2.5.7.1-7.diff.gz
 9e0f743c43aa55e4083d093beed5bb80f81bd947d5e3da14b9f2d9af15f4d45d 672894 d4x-common_2.5.7.1-7_all.deb
 fb4cae59247b4edaa3492ef9170c2f590b6d2c4b45f39331d2868113ba9a5318 731840 d4x_2.5.7.1-7_amd64.deb
Files: 
 187c1f2602b8589ccb1940fd5bfaa6ed 1736 net optional d4x_2.5.7.1-7.dsc
 61cc09c2cce848de262bbbc13a4d7bc6 44158 net optional d4x_2.5.7.1-7.diff.gz
 1cea6787f18afa966c39bb9ffd41268c 672894 net optional d4x-common_2.5.7.1-7_all.deb
 b9bdceedcb081860dd947abdbe9f3d23 731840 net optional d4x_2.5.7.1-7_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJLbDNuAAoJEDO+GgqMLtj/t3EP/2DTeGOV07xECQIz6JiLJccH
slXwM/4wRUYbHcUVUe90HpD2hUtWMO2TdbyLMGd2EFz8XbASrcuwh6hVmp4+46hA
uRJcVP8vbjCerSB4YPplra1e+DUlyQgWbHna4TO69B11OSQmEluQW8sZgEiIWNgU
+I54e/ZFcG2ch2cjphbu2hJbU+zmtIGKs19v56PmKbIdm/HsKQci8rxyANHyHhLw
tpn2ZBNYebFAESl5nYZzVL1T2c8LZJK/ZdvNfSuuNmJge1RlitdoY8Adxv8TRpDB
3t/syqU+yEkuM0Gy7m9s7iFdsS1NZwQGP0p0FbaJz1PElKcVa23D29LvfNykC14t
b2kLf96uolSoRTPflLHVDOEnG9I2B4c7pspNZoiRV6K4clFBdgD1tx/JHuIEP/Oo
CU2wmEi/Ip1mrBYlXMcGHnmE3qYvXYpJ/1jWGtz8tCvKX3VWOcisZUL17OisKtcI
H1L+F+7spoyq6OrE3qdNhIY6twRnQxvsyJgFZQ2Rk0O+Ibl6jgjtKg4FToJNrm5e
sNuacmlTQzj9krsd0Swh2t8R0wfdH3RqbNmRzIT4bQgZG+J9TqGV5dCYJXAgQiui
dUL9zd4flweAO3+Veah1bQk66eFIELkmVwf4b6e1O9/QCFNVtFbwHuUMd64voGGW
Ooq//v8J943qvFDGSNrI
=lpTc
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: