[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#521588: marked as done (Bugfixes for wmtz)

Your message dated Sun, 12 Sep 2010 16:02:17 +0000
with message-id <E1Oup0T-0004fk-Fr@merkel.debian.org>
and subject line Package wmtz has been removed from Debian
has caused the Debian Bug report #521588,
regarding Bugfixes for wmtz
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
521588: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521588
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: wmtz
Version: 0.7-8

wmtz has an open bug related to incorrect daylight savings time zone
string changes [See: Bug# #166526]. wmtz doesn't take into account the
zone name changes [e.g: EST to EDT for Eastern Standard to Eastern
Daylight]. This is a bug in code and I'm including a patch below.

One more issue that I've addressed (which IMHO is a useful fix to
avoid too many wakeups) is the sleep interval. wmtz seems to sleep for
10000 microseconds (effectively resulting in 100 wakeups per second).
This can quite safely be upped to 100000 microseconds, reducing
wakeups to 10 per second (and correspondingly changing the response
latency to a worst case of 0.1s which is quite OK since the only
option is a simple menu click).

This has improved power savings quite a bit as well as my processor
goes remains in the lower C states for far longer.

The patch is roughly [this is a diff of the final files after applying
the debian specific patches as well]

----------------------------------------------------------------------------------
--- wmtz.c      2001-04-16 15:26:34.000000000 -0400
+++ wmtz.new    2009-03-28 13:20:09.240867000 -0400
@@ -51,8 +51,7 @@
 #define STRSIZE 10
 #define LMST 1
 #define GMST 0
-#define ABOUT "xmessage -center -buttons \"Close\" \"WMTZ - Window
Maker Time Zone dockapp v0.7
-http://www.geocities.com/jl1n/wmtz/wmtz.html\"";
+#define ABOUT "xmessage -center -buttons \"Close\" \"WMTZ - Window
Maker Time Zone dockapp
v0.7\nhttp://www.geocities.com/jl1n/wmtz/wmtz.html\"";


 /*
@@ -401,7 +400,10 @@
              tzset();
              clk = localtime(&curtime);

-             strncpy(buf, tzname[0], 3);
+          // Obtain the Time Zone string
+          if (strftime(buf, sizeof(buf), "%Z", clk) == 0) {
+                strncpy(buf, tzname[0], 3);
+            }

               for (k=0; k<3; k++)
                 if (buf[k] == 0)
@@ -478,11 +480,10 @@
                    }
                   but_stat = -1;
                    break;
-           default:
          }
         }

-        usleep(10000);
+        usleep(100000);
     }
 }

@@ -528,7 +529,6 @@
        case 4:
            exit(0);
            break;
-       default:
       }
     return;
 }
----------------------------------------------------------------------------------

Please apply these fixes and confirm that the zone changes work.

Thanks.

Narayanan.

--- End Message ---
--- Begin Message --- 
Version: 0.7-9+rm

You filed the bug http://bugs.debian.org/521588 in Debian BTS
against the package wmtz. I'm closing it at *unstable*, but it will
remain open for older distributions.

For more information about this package's removal, read
http://bugs.debian.org/596550. That bug might give the reasons why
this package was removed and suggestions of possible replacements.

Don't hesitate to reply to this mail if you have any question.

Thank you for your contribution to Debian.

--
Luca Falavigna

--- End Message ---
Reply to: