[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#434681: marked as done (lslk: fails to list anything)

Your message dated Sun, 27 Jun 2010 18:02:07 +0000
with message-id <E1OSwBD-0000lM-U6@ries.debian.org>
and subject line Bug#434681: fixed in lslk 1.29-6
has caused the Debian Bug report #434681,
regarding lslk: fails to list anything
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

434681: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=434681
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lslk
Version: 1.29-3
Severity: important
Tags: patch

The function savelock() returns int, but the only return statements in it are
the ones that return 0 because of a failure. On success it just falls off the
end of the function returning some random left-over register value. This
random left-over value has a fairly good chance of being 0 (in fact it seems
to always be 0 in the ppc build.) Successes are interpreted as failures and
nothing gets printed.

Compiling with warnings enabled reveals a lot more questionable code, but
this fix at least gets it to print something.

--- lslk-1.29.orig/dialects/linux/proc/dlock.c
+++ lslk-1.29/dialects/linux/proc/dlock.c
@@ -339,4 +339,5 @@
  * Set the lock source to local; Linux doesn't support remote locking.
 	Lp->src = 0;
+	return 1;

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: powerpc (ppc)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages lslk depends on:
ii  libc6                       2.3.6.ds1-13 GNU C Library: Shared libraries

lslk recommends no packages.

-- debconf-show failed

--- End Message ---
--- Begin Message ---
Source: lslk
Source-Version: 1.29-6

We believe that the bug you reported is fixed in the latest version of
lslk, which is due to be installed in the Debian FTP archive:

  to main/l/lslk/lslk_1.29-6.debian.tar.gz
  to main/l/lslk/lslk_1.29-6.dsc
  to main/l/lslk/lslk_1.29-6_amd64.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 434681@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Ralf Treinen <treinen@debian.org> (supplier of updated lslk package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Sun, 27 Jun 2010 19:41:24 +0200
Source: lslk
Binary: lslk
Architecture: source amd64
Version: 1.29-6
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Ralf Treinen <treinen@debian.org>
 lslk       - Lock file lister
Closes: 434681
 lslk (1.29-6) unstable; urgency=low
   * QA upload
   * Source format 3.0 (quilt).
   * Added dependency on ${misc:Depends}.
   * Standards-Version 3.8.4 (no change).
   * Patch savelock-return-codes: return proper return codes from the function
     savelock(). Thanks to Alan Curry for the patch! (closes: #434681)
   * debian/rules:
     - remove generated Makefile and .ckMANIFEST in clean target.
     - actually compile the program in the build-stamp target, instead of
       relying on the install target to call on the compilation.
   * removed file debian/substvars from the source package.
 aba9d966560575b0d3b8fc65634b96be79cbd832 937 lslk_1.29-6.dsc
 565103f5bbe91ee2627c9cc18a258c4ea32536fc 2955 lslk_1.29-6.debian.tar.gz
 7e75253702298a2ec1cb807141845a80fb1a6f65 27724 lslk_1.29-6_amd64.deb
 cbd83f550d0ddfa2f4df6d178e8ec5251f7fed1bb8a8dab6135344103e55f9c9 937 lslk_1.29-6.dsc
 b366fb5bcd43bace0f80464070770f0bd68aee0628de344c9ab3c10a3ae4ac8b 2955 lslk_1.29-6.debian.tar.gz
 3d185ab6c64428450cc6a7bc9d700d92cf4fa8b0269dfbee734674937ec0d84a 27724 lslk_1.29-6_amd64.deb
 662b75401dd993c9ae7b8d4e42b7f0bf 937 utils optional lslk_1.29-6.dsc
 80114d03946282f40fc8a87ce0b7c28d 2955 utils optional lslk_1.29-6.debian.tar.gz
 90c50c221c6144df032ffa92e34d2c31 27724 utils optional lslk_1.29-6_amd64.deb

Version: GnuPG v1.4.10 (GNU/Linux)


--- End Message ---

Reply to: