[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#582399: marked as done (Sopwith doesn't compile properly on Ubuntu 9.10)



Your message dated Sat, 19 Jun 2010 22:07:40 +0000
with message-id <E1OQ6CS-0003eQ-VG@ries.debian.org>
and subject line Bug#582399: fixed in sopwith 1.7.3-1
has caused the Debian Bug report #582399,
regarding Sopwith doesn't compile properly on Ubuntu 9.10
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
582399: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=582399
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: sopwith
Version: 1.7.1

The sopwith source code doesn't compile properly on Ubuntu with gcc
4.4.1. Specifically, there is a header call to string.h missing from the
vga code and a variable which is declared static in one source file and
extern in a header file. The attached patch fixes these bugs to allow
sopwith to compile on downstream Ubuntu.

diff -au sopwith-1.7.1/src/swmain.h sopwith-1.7.2/src/swmain.h
--- sopwith-1.7.1/src/swmain.h	2003-06-08 15:20:30.000000000 -0300
+++ sopwith-1.7.2/src/swmain.h	2010-05-19 19:47:07.000000000 -0300
@@ -46,7 +46,8 @@
 extern int     targrnge;
 extern BOOL    hires;
 extern BOOL    disppos;
-extern BOOL    titleflg;
+// extern BOOL    titleflg;
+static BOOL titleflg;
 extern int     dispdbg;
 extern BOOL    soundflg;
 extern BOOL    repflag;
diff -au sopwith-1.7.1/src/swsound.c sopwith-1.7.2/src/swsound.c
--- sopwith-1.7.1/src/swsound.c	2003-06-08 15:20:30.000000000 -0300
+++ sopwith-1.7.2/src/swsound.c	2010-05-19 19:46:58.000000000 -0300
@@ -79,7 +79,8 @@
 };
 #endif
 
-static BOOL titleflg;		/* Playing title tune               */
+// static BOOL titleflg;		/* Playing title tune               */
+extern BOOL titleflg;
 static int titlplace;		/*  Place in title tune;            */
 static int titlline;		/* Line in title tune               */
 static unsigned titltone;	/*  Current title tone              */
diff -au sopwith-1.7.1/src/vid_vga.c sopwith-1.7.2/src/vid_vga.c
--- sopwith-1.7.1/src/vid_vga.c	2003-06-08 15:20:30.000000000 -0300
+++ sopwith-1.7.2/src/vid_vga.c	2010-05-19 19:37:36.000000000 -0300
@@ -22,6 +22,8 @@
 //
 //---------------------------------------------------------------------------
 
+#include <string.h>
+
 #include "video.h"
 
 #include "sw.h"

--- End Message ---
--- Begin Message ---
Source: sopwith
Source-Version: 1.7.3-1

We believe that the bug you reported is fixed in the latest version of
sopwith, which is due to be installed in the Debian FTP archive:

sopwith_1.7.3-1.debian.tar.gz
  to main/s/sopwith/sopwith_1.7.3-1.debian.tar.gz
sopwith_1.7.3-1.dsc
  to main/s/sopwith/sopwith_1.7.3-1.dsc
sopwith_1.7.3-1_amd64.deb
  to main/s/sopwith/sopwith_1.7.3-1_amd64.deb
sopwith_1.7.3.orig.tar.gz
  to main/s/sopwith/sopwith_1.7.3.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 582399@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ralf Treinen <treinen@debian.org> (supplier of updated sopwith package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 19 Jun 2010 22:44:08 +0200
Source: sopwith
Binary: sopwith
Architecture: source amd64
Version: 1.7.3-1
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Ralf Treinen <treinen@debian.org>
Description: 
 sopwith    - port of the 1980's side-scrolling WWI dogfighting game
Closes: 187930 188391 224518 258751 582399 585929
Changes: 
 sopwith (1.7.3-1) unstable; urgency=low
 .
   * QA upload
   * New upstream release (closes: #585929). This release fixes the
     following upstream bugs:
     - Range check and missile firing bug fixed (closes: #224518, #258751)
     - Mouse pointer no longer appears over the game window (closes: #187930)
     - Throttle now goes up and down smoothly (closes: #188391)
     - Cleaned up compiler warnings and errors (closes: #582399)
     Thanks to Jesse Smith for compiling this list of closed upstream bugs.
   * Fixed debian/watch, use new name of upstream tarball.
   * DH-compat level 5, bumped versioned dependency on debhelper.
   * Switch to source format 3.0 (quilt).
   * debian/rules: removed invocation of deprecated dh_desktop.
   * debian/control: added dependency on ${misc:Depends}.
   * debian/copyright: symlink to versionend GPL file.
Checksums-Sha1: 
 273b54b12def6d32dcd67830b0d500f521c45eb9 1082 sopwith_1.7.3-1.dsc
 0047b2e17c41e60f60cbaa2079fff60add05f1e4 259728 sopwith_1.7.3.orig.tar.gz
 dd122a77403500c7285fb17a6199276ebcc6cc56 25641 sopwith_1.7.3-1.debian.tar.gz
 e9ac56109e2b69756db183428db8cae1fdb59d4e 59896 sopwith_1.7.3-1_amd64.deb
Checksums-Sha256: 
 588d3da3f8a7bb232a204aca8abca80a425c6ce47cf0a6097526d552873075f5 1082 sopwith_1.7.3-1.dsc
 580e7c34d08d831491695965e3fef4ab3dbea097fee97537ceddf1f4bdad0e17 259728 sopwith_1.7.3.orig.tar.gz
 860a724d363aec93faf6ddf2b9f51657af9e64aa6397516e5030ac77d9c56ba6 25641 sopwith_1.7.3-1.debian.tar.gz
 505664ffdb9a8734e0d4669d4ea0a627e4d3b530121205385714b2d251c2ccf4 59896 sopwith_1.7.3-1_amd64.deb
Files: 
 458baf3b1a393a1af68ea3ad236ce8a7 1082 games optional sopwith_1.7.3-1.dsc
 9520e687b9f573e340d4308aa3010b13 259728 games optional sopwith_1.7.3.orig.tar.gz
 a4f721e28901636a6b936a4419be7862 25641 games optional sopwith_1.7.3-1.debian.tar.gz
 b3bb3061888a81c09a84fdee17d5a96e 59896 games optional sopwith_1.7.3-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMHTADtzWmSeC6BMERAp7CAJ94Kl3JCFWO2Htn0YvVgRBZLXcAxwCaAn5j
q5YUbqOJMZyiDEt0VnrAOQM=
=l0h5
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: